Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bike mod #40

Open
2 of 3 tasks
Tracked by #123
Ygarr opened this issue Feb 15, 2021 · 24 comments · May be fixed by #123
Open
2 of 3 tasks
Tracked by #123

Bike mod #40

Ygarr opened this issue Feb 15, 2021 · 24 comments · May be fixed by #123
Labels
breaks-rule9 This mod is currently incompatible with other whynot mods. new-mod-proposal Consider the mod can be applied to the game Wait for upstream fix Mod needs a fix in upsteam

Comments

@Ygarr
Copy link

Ygarr commented Feb 15, 2021

Request for add bike(bicycle) mod


This section added by @Lazerbeak12345 to include the issue links in OP - ensuring this has a checklist.

Also of note, but not required before a fix

@bell07
Copy link
Collaborator

bell07 commented Feb 16, 2021

Please post a link to the mod source you mean

@Ygarr
Copy link
Author

Ygarr commented Feb 16, 2021

@Ygarr
Copy link
Author

Ygarr commented Feb 20, 2021

Bike mod from ContentDB is working IF "skinsdb"(or "simple skin") mod is also present

@bell07
Copy link
Collaborator

bell07 commented Feb 20, 2021

Ok, I see. Then the mod needs to be ported into my enhanced player_api first

@bell07 bell07 added the new-mod-proposal Consider the mod can be applied to the game label Jan 7, 2022
@bell07 bell07 self-assigned this Jan 7, 2022
@bell07
Copy link
Collaborator

bell07 commented Feb 23, 2022

If #62 is merged, no porting necessary anymore

@bell07 bell07 removed their assignment Feb 24, 2022
@Lazerbeak12345
Copy link
Collaborator

Lazerbeak12345 commented Apr 12, 2022

Playtest review:

Everything seems craftable, though there were odd error messages when changing the color of a bike.

ERROR[Main]: Invalid color ""
ERROR[Main]: generateImage(): Failed to generate "[colorize::"

the color doesn't always change


Issue posted at gitlab.com/h2mm/bike/-/issues/12

@Lazerbeak12345
Copy link
Collaborator

Lazerbeak12345 commented Apr 12, 2022

The color gun should get used over time, and require a repair (currently doesn't)


Issue posted at gitlab.com/h2mm/bike/-/issues/13

@dacmot
Copy link
Collaborator

dacmot commented Apr 12, 2022

These issues should probably be reported upstream. I would consider the color errors fix mandatory before inclusion. I agree with the paint gun, to fit with other tools in the game.

https://gitlab.com/h2mm/bike

@Lazerbeak12345
Copy link
Collaborator

Issues made.

@Lazerbeak12345
Copy link
Collaborator

Lazerbeak12345 commented Apr 12, 2022

My opinion on how it fits with the whynot rules:

Refer to the Whynot Readme for full rule descriptions/reasons.

  1. In what ways might this mod take over the game?
    • None. It's only a bike, and tools to customize your 🔥🚲🔥 sick ride 🔥🚲🔥
  2. When could this mod be a strain on the server when no players are using the mod?
    • Never. No code is used when players aren't involved.
  3. When does this mod destroy player's work?
    • Never.
  4. Have you looked at the code? If so, what stood out as things that might need fixing?
    • It's a bit hard to read. Thought there for a moment that it didn't support multiplayer. A bit of testing proved otherwise.
  5. In what way might this mod be reduced to be more simple (as in "Keep it Simple Stupid") (ex: "the foobar mod could be made more simple by splitting into two mods, foo and bar")
    • The color gun could be aliased to VannessaE's paint gun when present, meaning the user only sees one color gun in the craft guide.
    • This could use a mob library to offload most of the math, and improve performance.
  6. Is this mod survival freindly? What items that it provides that should be craftable/obtainable, but aren't?
    • Very. It doesn't miss anything. (Fallback crafts are provided if certain mods not present)
  7. When does this mod feel like cheating?
  8. Does this mod use the software "git" for version control? (note: we are asking about git. Github, Gitlab, notabug and hundreds of other git providers exist but are not specifically needed, although these do qualify).
    • Yes
  9. Upon testing this mod, what errors, odd behavior, or other incompatibilities were noticed?

Other comments

Great mod. Me and my brother love it.

@Lazerbeak12345
Copy link
Collaborator

Lazerbeak12345 commented Apr 12, 2022

Darn. Internet issue. My review never actually was commented. I'll re-review in a bit.

edit: nvm it just did.

@Lazerbeak12345 Lazerbeak12345 added breaks-rule7 This mod currently breaks game balancing or feels like a "cheat". breaks-rule9 This mod is currently incompatible with other whynot mods. labels Apr 13, 2022
@Lazerbeak12345 Lazerbeak12345 added the Wait for upstream fix Mod needs a fix in upsteam label May 24, 2022
@Lazerbeak12345
Copy link
Collaborator

The related gitlab repo seems to be dead. No commits in about a year, and no interaction with issues in a very long time.

@dacmot
Copy link
Collaborator

dacmot commented Aug 12, 2022

That's unfortunate. The author still seems active on Gitlab. Maybe (hopefully) he's just too busy for minetest at the moment. I'd keep it open for now as it looks like a cool mod.

@Lazerbeak12345
Copy link
Collaborator

The error isn't happening anymore. @dacmot or @bell07 what do you feel about rule 7 in the context of this mod?

@Lazerbeak12345 Lazerbeak12345 removed the breaks-rule9 This mod is currently incompatible with other whynot mods. label Aug 14, 2022
@Lazerbeak12345
Copy link
Collaborator

Also, they've replied to a comment (about 2 days ago) for the first time in a long time.

@dacmot
Copy link
Collaborator

dacmot commented Aug 15, 2022

Good news. Maybe the error disappeared in a minetest update or other mods in whynot.

As for the mod, I don't know if the paint gun thing is reason enough not to include it. There's an issue opened upstream and it's been acknowledged by the mod author. I would be OK to give it a go.

@Lazerbeak12345
Copy link
Collaborator

Alright, I'd argue the rule 9 breakage is trivial then. It's not really breaking the rule anyway.

@Lazerbeak12345 Lazerbeak12345 removed Wait for upstream fix Mod needs a fix in upsteam breaks-rule7 This mod currently breaks game balancing or feels like a "cheat". labels Aug 17, 2022
@Lazerbeak12345 Lazerbeak12345 self-assigned this Aug 17, 2022
@Lazerbeak12345 Lazerbeak12345 linked a pull request Aug 17, 2022 that will close this issue
2 tasks
@dacmot
Copy link
Collaborator

dacmot commented Sep 1, 2022

Just tried this and I have a few issues with it:

  1. Crashes with character creator (https://gitlab.com/h2mm/bike/-/issues/15)
  2. Running up against a wall (2-blocks high or more) ends up with underground vision (https://gitlab.com/h2mm/bike/-/issues/16)
  3. It's not obvious how to get off. I would have expected something similar to boats: right-click on, right-click off... anything but shift.
  4. Would be nice to be able to climb using wheely (space bar)
  5. Note to self: don't use bicycle under water. It sinks really fast.

Updated OP with new issues.

@Lazerbeak12345
Copy link
Collaborator

On point 4, it does support slopes and slabs. I think it should support blocks, however.

@Lazerbeak12345 Lazerbeak12345 linked a pull request Sep 9, 2022 that will close this issue
2 tasks
@Lazerbeak12345 Lazerbeak12345 added the breaks-rule9 This mod is currently incompatible with other whynot mods. label Sep 16, 2022
@Lazerbeak12345 Lazerbeak12345 moved this to Awaiting Upstream Issues in Add New Game Content Dec 16, 2022
@bell07
Copy link
Collaborator

bell07 commented Dec 17, 2022

Skinsdb support MC-1.8 Skins format. (My source: https://minecraft.novaskin.me/)
Bike does not fully support them :-(

@Lazerbeak12345
Copy link
Collaborator

I've made a PR to bike with your suggested change. https://gitlab.com/h2mm/bike/-/merge_requests/18

It should fix https://gitlab.com/h2mm/bike/-/issues/15

@Lazerbeak12345 Lazerbeak12345 added the Wait for upstream fix Mod needs a fix in upsteam label Jan 16, 2023
@dacmot
Copy link
Collaborator

dacmot commented Jan 19, 2023

Nice! Simple fix. I like it :)

@Lazerbeak12345
Copy link
Collaborator

That PR was accepted. Now we only wait on https://gitlab.com/h2mm/bike/-/issues/16

@dacmot
Copy link
Collaborator

dacmot commented Apr 17, 2023

Hume2 mentioned changing the hitbox would break the physics. I'm asking if changing the viewpoint would be another avenue for resolving this.

@Lazerbeak12345 Lazerbeak12345 removed their assignment Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaks-rule9 This mod is currently incompatible with other whynot mods. new-mod-proposal Consider the mod can be applied to the game Wait for upstream fix Mod needs a fix in upsteam
Projects
Status: Awaiting Upstream Issues
Development

Successfully merging a pull request may close this issue.

4 participants