-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bike mod #40
Comments
Please post a link to the mod source you mean |
Bike mod from ContentDB is working IF "skinsdb"(or "simple skin") mod is also present |
Ok, I see. Then the mod needs to be ported into my enhanced player_api first |
If #62 is merged, no porting necessary anymore |
Playtest review: Everything seems craftable, though there were odd error messages when changing the color of a bike.
the color doesn't always change Issue posted at gitlab.com/h2mm/bike/-/issues/12 |
The color gun should get used over time, and require a repair (currently doesn't) Issue posted at gitlab.com/h2mm/bike/-/issues/13 |
These issues should probably be reported upstream. I would consider the color errors fix mandatory before inclusion. I agree with the paint gun, to fit with other tools in the game. |
Issues made. |
My opinion on how it fits with the whynot rules:
Other commentsGreat mod. Me and my brother love it. |
Darn. Internet issue. My review never actually was commented. I'll re-review in a bit. edit: nvm it just did. |
The related gitlab repo seems to be dead. No commits in about a year, and no interaction with issues in a very long time. |
That's unfortunate. The author still seems active on Gitlab. Maybe (hopefully) he's just too busy for minetest at the moment. I'd keep it open for now as it looks like a cool mod. |
Also, they've replied to a comment (about 2 days ago) for the first time in a long time. |
Good news. Maybe the error disappeared in a minetest update or other mods in whynot. As for the mod, I don't know if the paint gun thing is reason enough not to include it. There's an issue opened upstream and it's been acknowledged by the mod author. I would be OK to give it a go. |
Alright, I'd argue the rule 9 breakage is trivial then. It's not really breaking the rule anyway. |
Just tried this and I have a few issues with it:
Updated OP with new issues. |
On point 4, it does support slopes and slabs. I think it should support blocks, however. |
Skinsdb support MC-1.8 Skins format. (My source: https://minecraft.novaskin.me/) |
I've made a PR to bike with your suggested change. https://gitlab.com/h2mm/bike/-/merge_requests/18 It should fix https://gitlab.com/h2mm/bike/-/issues/15 |
Nice! Simple fix. I like it :) |
That PR was accepted. Now we only wait on https://gitlab.com/h2mm/bike/-/issues/16 |
Hume2 mentioned changing the hitbox would break the physics. I'm asking if changing the viewpoint would be another avenue for resolving this. |
Request for add bike(bicycle) mod
This section added by @Lazerbeak12345 to include the issue links in OP - ensuring this has a checklist.
Also of note, but not required before a fix
The text was updated successfully, but these errors were encountered: