Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trailing whitespace in username leads to invalid credentials #3422

Closed
saschadoemer opened this issue Aug 8, 2024 · 4 comments · Fixed by #3496
Closed

Trailing whitespace in username leads to invalid credentials #3422

saschadoemer opened this issue Aug 8, 2024 · 4 comments · Fixed by #3496
Assignees
Labels
bug this needs to be fixed community

Comments

@saschadoemer
Copy link

Expected Behavior

As a user, I would expect trailing spaces to be removed in case I copied them with trailing spaces from messages, mails or something else.

Current Behavior

The current version uses the username as it is. Therefore, trailing spaces are used as part of the login and cause an invalid login, which just leads to highlighted fields without any further information.

image

Leads to the following outcome:

image

The trailing space is hard to notice, and the UI is giving no hint.

Additional information

Thanks for the awesome work ❤️

@cesnietor
Copy link
Collaborator

thanks for reporting @saschadoemer, PRs are welcome.

@cesnietor cesnietor added bug this needs to be fixed and removed triage labels Aug 8, 2024
@saschadoemer
Copy link
Author

I'll try, let me check the code 😃

@cesnietor cesnietor removed their assignment Dec 23, 2024
@changchaishi
Copy link
Contributor

Hi, I would like to work on this. Is that okay?

Based on what I observed on other websites (for instance, Github), it accepts trailing space and handles it on the backend server.
The change will be like strings.TrimRight(accessKey, " ") to get the console credentials.

I will file the PR if this is ok. Thanks.

@ramondeklein
Copy link
Collaborator

Please go ahead and file a PR. I would both trim spaces both at the beginning and end. It's not very likely that someone would use spaces in the beginning or end of it's username/password. And if you do, you we're asking for trouble 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug this needs to be fixed community
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants