Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected behavior: Pressing Enter in Object Browser triggers file upload dialog #3480

Open
GareevRinat opened this issue Nov 28, 2024 · 3 comments
Assignees

Comments

@GareevRinat
Copy link

Expected Behavior

Pressing the Enter key in the Object Browser should not trigger the file upload dialog unless the focus is explicitly on an actionable element (e.g., a button or input field specifically designed for file uploads). The behavior should be context-sensitive and should not override standard keyboard expectations.

Current Behavior

In the Object Browser, pressing the Enter key opens the file upload dialog regardless of the current focus. This happens even if no actionable elements (like buttons) are focused, leading to unexpected and non-intuitive behavior.

Possible Solution

Restrict the Enter key action to trigger the file upload dialog only when focus is explicitly on the "Upload" button or related file selection input. For all other cases, the Enter key should have no effect unless explicitly mapped to a specific action.

Steps to Reproduce (for bugs)

  1. Navigate to the Object Browser in the MinIO admin console.
  2. Select any bucket.
  3. Click anywhere in the interface (e.g., an empty space or text input field).
  4. Press the Enter key.
  5. Observe that the file upload dialog opens unexpectedly, even though no file-related action was initiated.

Context

This issue creates a confusing user experience by overriding expected keyboard interactions. For example, users may accidentally open the upload dialog when they intended to confirm an unrelated input or action. This can disrupt workflows, especially in cases where the user works with keyboard navigation.

Regression

Unknown

Your Environment

  • Version used (minio --version): Not available, as I am reporting this issue as a user and do not have access to the server or environment details.
  • Server setup and configuration: Not available.
  • Operating System and version (uname -a): Not available, as this issue is being reported from the MinIO web interface.
@harshavardhana harshavardhana transferred this issue from minio/minio Nov 28, 2024
@cesnietor
Copy link
Collaborator

@GareevRinat we need to know the MinIO version you are running. We fixed a similar issue long time ago and this might be already solved. We'll try to reproduce in the latest version.

You could see the MinIO version by going to Health tab e.g.
Image

@GareevRinat
Copy link
Author

@cesnietor MinIO VERSION: 2024-09-22T00:33:43Z

@cesnietor
Copy link
Collaborator

cc @bexsoft ^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants