Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pattern Matching docs do not make sense? #1397

Open
shoce opened this issue Jan 17, 2025 · 3 comments
Open

Pattern Matching docs do not make sense? #1397

shoce opened this issue Jan 17, 2025 · 3 comments
Labels
triage Needs triage and scheduling

Comments

@shoce
Copy link

shoce commented Jan 17, 2025

Looking at the Pattern Matching docs https://github.com/minio/docs/blob/main/source/reference/minio-mc.rst#pattern-matching i barely can see the point.

Let's take the first example:

Pattern | Text | Match Result
abc*    | ab   | Match

it does not make sense to me, as the pattern starts with abc and the text is even shorter.

Another example from the docs:

Pattern | Text | Match Result
abc*c   | abcd | Match

also confuses me a lot - the pattern ends with c and the text does not.

@shoce shoce added the triage Needs triage and scheduling label Jan 17, 2025
@ravindk89
Copy link
Collaborator

6cae178

hm - @djwfyi do you recall at all where the pattern matching stuff came from? Inclined to agree it looks wrong, but this looks like a table we would have pulled from elsewhere.

Either way seems fine to go through and clean it up, these should be similar to glob matching rules.

@djwfyi
Copy link
Collaborator

djwfyi commented Jan 17, 2025

@ravindk89
Copy link
Collaborator

@donatello this looks a few years old - if most of our pattern matching boils down to blob-style we can say that and ditch the table. Or if you can recall how this came about that might help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage Needs triage and scheduling
Projects
None yet
Development

No branches or pull requests

3 participants