Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AddUser() method name #156

Open
Lxrdknows77 opened this issue Nov 25, 2022 · 0 comments
Open

AddUser() method name #156

Lxrdknows77 opened this issue Nov 25, 2022 · 0 comments

Comments

@Lxrdknows77
Copy link

In fact behaviour of this method depends if user already exists or not, and in 1st case it will just update his secret key (and status). Thus, for more transparency would be better maybe to change it to e.g CreateOrUpdateUser? Or at least add additional comment up of the method definition.

func (adm *AdminClient) AddUser(ctx context.Context, accessKey, secretKey string) error {

@Lxrdknows77 Lxrdknows77 changed the title Change name of the method AddUser() to CreateOrUpdateUser(). AddUser() method name Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant