add = character to tag validation regex

minio · Oct 11, 2024 · c514bc6 · c514bc6
1 parent cca4103
commit c514bc6
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/pkg/tags/tags.go b/pkg/tags/tags.go
@@ -69,7 +69,7 @@ const (
 // https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/Using_Tags.html#tag-restrictions
 // borrowed from this article and also testing various ASCII characters following regex
 // is supported by AWS S3 for both tags and values.
-var validTagKeyValue = regexp.MustCompile(`^[a-zA-Z0-9-+\-._:/@ ]+$`)
+var validTagKeyValue = regexp.MustCompile(`^[a-zA-Z0-9-+\-._:/@ =]+$`)
 
 func checkKey(key string) error {
 	if len(key) == 0 {

diff --git a/pkg/tags/tags_test.go b/pkg/tags/tags_test.go
@@ -43,6 +43,11 @@ func TestParseTags(t *testing.T) {
 			false,
 			2,
 		},
+		{
+			"key=value=",
+			false,
+			1,
+		},
 		{
 			fmt.Sprintf("%0128d=%0256d", 1, 1),
 			false,
-Original file line number
+Diff line change
@@ Expand Up / @@ -43,6 +43,11 @@ func TestParseTags(t *testing.T) { @@
     			false,
 ,
     		},
+    		{
+    			"key=value=",
+    			false,
+,
+    		},
     		{
     			fmt.Sprintf("%0128d=%0256d", 1, 1),
     			false,
@@ Expand Down @@