Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Add functional tests for bucket tagging #1552

Closed
vadmeste opened this issue Sep 18, 2021 · 4 comments
Closed

tests: Add functional tests for bucket tagging #1552

vadmeste opened this issue Sep 18, 2021 · 4 comments
Assignees

Comments

@vadmeste
Copy link
Member

Add functional tests for bucket tagging, PUT/GET/DELETE.

@vadmeste vadmeste self-assigned this Sep 18, 2021
@romanchechyotkin
Copy link
Contributor

Hello, this task is 3 years old, but i can do it, wanna start my opensource adventure.
Is this still valid issue?

@klauspost
Copy link
Contributor

@romanchechyotkin Good first topic indeed! I don't see it added to the repo.

It should be added to functional_tests.go. Add an entry. When I do it, I just add it at the top and add a temporary "return". To start out maybe copy an existing like testMakeBucketError and modify that.

I then run it against a local minio install with a simple script. You can adapt that to your needs:

SET ACCESS_KEY=minio
SET SECRET_KEY=minio123
SET SERVER_ENDPOINT=127.0.0.1:9001
SET MINT_DATA_DIR=
SET MINT_MODE=full
SET ENABLE_HTTPS=false
SET ENABLE_KMS=true

go build functional_tests.go && functional_tests

romanchechyotkin added a commit to romanchechyotkin/minio-go that referenced this issue Jul 16, 2024
@romanchechyotkin
Copy link
Contributor

romanchechyotkin commented Jul 16, 2024

#1986 here is my PR
free to criticism

@harshavardhana
Copy link
Member

harshavardhana commented Jul 16, 2024

Task completed via #1986

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants