Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

virtual-hosted-style option #346

Closed
LancGH opened this issue Nov 15, 2024 · 3 comments · Fixed by #347
Closed

virtual-hosted-style option #346

LancGH opened this issue Nov 15, 2024 · 3 comments · Fixed by #347

Comments

@LancGH
Copy link

LancGH commented Nov 15, 2024

Hi!

It seems that binary warp does'nt support option related to the virtual-hosted-style requests, path-style only.
Do you have a plan to include this option in the future releases?
Or may be it can be changed somewhere in source code as workaround.

Thanks.

klauspost added a commit to klauspost/warp that referenced this issue Nov 15, 2024
Instead of always auto-detecting, allow setting explicitly with `--lookup=host` or `--lookup=path`.

Fixes minio#346
@klauspost
Copy link
Collaborator

Added in #347

@LancGH
Copy link
Author

LancGH commented Nov 15, 2024

Thank's a lot!

harshavardhana pushed a commit to klauspost/warp that referenced this issue Nov 19, 2024
Instead of always auto-detecting, allow setting explicitly with `--lookup=host` or `--lookup=path`.

Fixes minio#346
harshavardhana pushed a commit that referenced this issue Nov 19, 2024
Instead of always auto-detecting, allow setting explicitly with `--lookup=host` or `--lookup=path`.

Fixes #346
@ADustyOldMuffin
Copy link

👋🏻 Hey @klauspost do you know when a release will be cut with this change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants