Torch check compatibility fails at torch

[d3sm0]

This compatibility check pass if torch in requirements.txt but it installs rocm version. I think it should be strict on the version torch1.10.1+cu110.

experiment_buddy/experiment_buddy/experiment_buddy.py

Line 260 in b7de02b

if "torch" not in reqs and "torch==1.7.1+cu110" not in reqs:

[manuel-delverme]

why 1.10+cu110? any version will do, no?

…

On Sun, 9 Jan 2022 at 16:40, d3sm0 ***@***.***> wrote: Assigned #108 <#108> to @manuel-delverme <https://github.com/manuel-delverme>. — Reply to this email directly, view it on GitHub <#108 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJ7ZYWVQRUU6AQTCJNXIPTUVH6DLANCNFSM5LSKBXZA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you were assigned.Message ID: <ministry-of-silly-code/experiment_buddy/issue/108/issue_event/5862790809@ github.com>

[d3sm0]

because on mila cluster is the latest pytorch version that has the cuda version that we have access to. It doesn't really matter which version we specify, as long as there is a version with explicit cuda request.
The bit that fails is to specify torch only nor the version itself.

[manuel-delverme]

import re

matches = re.search(r"torch==.*cu.*", reqs)

if "torch" in reqs and not matches:

would be ok?

I want to let people use any cuda version.

also, extra_modules should be checked i guess.

[d3sm0]

this would work. Thank you!

No need to check for modules if module version is the same as the one specified in reqs then nothing should happen (my guess) otherwise pip version wins.