Skip to content

Commit

Permalink
remove legacy dependence variable (#75)
Browse files Browse the repository at this point in the history
Co-authored-by: sj-williams <[email protected]>
  • Loading branch information
jaskaransarkaria and sj-williams authored Feb 19, 2024
1 parent 98e8870 commit 72bb263
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 10 deletions.
1 change: 0 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ No modules.
| <a name="input_cluster_domain_name"></a> [cluster\_domain\_name](#input\_cluster\_domain\_name) | The cluster domain used for externalDNS annotations and certmanager | `any` | n/a | yes |
| <a name="input_controller_name"></a> [controller\_name](#input\_controller\_name) | Will be used as the ingress controller name and the class annotation | `string` | n/a | yes |
| <a name="input_default_cert"></a> [default\_cert](#input\_default\_cert) | Useful if you want to use a default certificate for your ingress controller. Format: namespace/secretName | `string` | `"ingress-controllers/default-certificate"` | no |
| <a name="input_dependence_certmanager"></a> [dependence\_certmanager](#input\_dependence\_certmanager) | cert-manager module dependences in order to be executed. | `any` | n/a | yes |
| <a name="input_enable_external_dns_annotation"></a> [enable\_external\_dns\_annotation](#input\_enable\_external\_dns\_annotation) | Add external dns annotation for service | `bool` | `false` | no |
| <a name="input_enable_latest_tls"></a> [enable\_latest\_tls](#input\_enable\_latest\_tls) | Provide support to tlsv1.3 along with tlsv1.2 | `bool` | `false` | no |
| <a name="input_enable_modsec"></a> [enable\_modsec](#input\_enable\_modsec) | Enable https://github.com/SpiderLabs/ModSecurity-nginx | `bool` | `false` | no |
Expand Down
2 changes: 0 additions & 2 deletions example/ingress.tf
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ module "ingress_controllers" {
cluster_domain_name = "dummy"
is_live_cluster = false
live1_cert_dns_name = "dummy"
dependence_certmanager = "ignore"

}

Expand All @@ -20,7 +19,6 @@ module "modsec_ingress_controllers" {
live1_cert_dns_name = "dummy"
enable_modsec = true
enable_owasp = true
dependence_certmanager = "ignore"

depends_on = [module.ingress_controllers]
}
4 changes: 1 addition & 3 deletions main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,6 @@ resource "helm_release" "nginx_ingress" {
depends_on = [
kubernetes_namespace.ingress_controllers,
kubernetes_config_map.modsecurity_nginx_config,
var.dependence_certmanager
]

lifecycle {
Expand Down Expand Up @@ -99,7 +98,6 @@ resource "kubectl_manifest" "nginx_ingress_default_certificate" {
yaml_body = data.template_file.nginx_ingress_default_certificate.rendered

depends_on = [
kubernetes_namespace.ingress_controllers,
var.dependence_certmanager
kubernetes_namespace.ingress_controllers
]
}
4 changes: 0 additions & 4 deletions variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -68,10 +68,6 @@ variable "enable_external_dns_annotation" {
default = false
}

variable "dependence_certmanager" {
description = "cert-manager module dependences in order to be executed."
}

variable "cluster" {
description = " cluster name used for opensearch indicies"
type = string
Expand Down

0 comments on commit 72bb263

Please sign in to comment.