From 25cdce617c865272b83ae71e34e214845f41d2dc Mon Sep 17 00:00:00 2001 From: poornima-moj Date: Tue, 9 Jun 2020 16:30:30 +0100 Subject: [PATCH 1/2] Update example for db_parameter changes --- example/rds.tf | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/example/rds.tf b/example/rds.tf index e1b89ba..0b7b553 100644 --- a/example/rds.tf +++ b/example/rds.tf @@ -27,14 +27,14 @@ module "example_team_rds" { team_name = "example-repo" business-unit = "example-bu" application = "exampleapp" - is-production = "false" + is-production = "false" # If the rds_name is not specified a random name will be generated ( cp-* ) # Changing the RDS name requires the RDS to be re-created (destroy + create) # rds_name = "my-rds-name" # enable performance insights - performance_insights_enabled = true + performance_insights_enabled = true # change the postgres version as you see fit. db_engine_version = "10" @@ -47,7 +47,14 @@ module "example_team_rds" { # Some engines can't apply some parameters without a reboot(ex postgres9.x cant apply force_ssl immediate). # You will need to specify "pending-reboot" here, as default is set to "immediate". - apply_method = "pending-reboot" + db_parameter = [ + { + name = "rds.force_ssl" + value = "true" + apply_method = "pending-reboot" + } + ] + # use "allow_major_version_upgrade" when upgrading the major version of an engine allow_major_version_upgrade = "true" From 623fe0859495f1d0c403a74d1c2339cb22c9f16c Mon Sep 17 00:00:00 2001 From: poornima-moj Date: Tue, 9 Jun 2020 16:35:05 +0100 Subject: [PATCH 2/2] Commenting the db_parameter as it is only optional --- example/rds.tf | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/example/rds.tf b/example/rds.tf index 0b7b553..5fd741f 100644 --- a/example/rds.tf +++ b/example/rds.tf @@ -47,13 +47,13 @@ module "example_team_rds" { # Some engines can't apply some parameters without a reboot(ex postgres9.x cant apply force_ssl immediate). # You will need to specify "pending-reboot" here, as default is set to "immediate". - db_parameter = [ - { - name = "rds.force_ssl" - value = "true" - apply_method = "pending-reboot" - } - ] + # db_parameter = [ + # { + # name = "rds.force_ssl" + # value = "true" + # apply_method = "pending-reboot" + # } + # ] # use "allow_major_version_upgrade" when upgrading the major version of an engine