Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version used in template and by CLI to latest release #80

Merged
merged 2 commits into from
Oct 31, 2023
Merged

Bump version used in template and by CLI to latest release #80

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c6793e3
Bump version used in template and by CLI to latest release
jakemulley Oct 31, 2023
0dd720a
Update s3.tf
jakemulley Oct 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 5 additions & 35 deletions examples/s3.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,14 @@
*
*/
module "s3_bucket" {
source = "github.com/ministryofjustice/cloud-platform-terraform-s3-bucket?ref=5.1.0"

source = "github.com/ministryofjustice/cloud-platform-terraform-s3-bucket?ref=4.8.2"
team_name = var.team_name
business-unit = var.business_unit
business_unit = var.business_unit
application = var.application
is-production = var.is_production
environment-name = var.environment
infrastructure-support = var.infrastructure_support
is_production = var.is_production
environment_name = var.environment
infrastructure_support = var.infrastructure_support
namespace = var.namespace

/*
Expand Down Expand Up @@ -143,36 +143,6 @@ module "s3_bucket" {
}
EOF
*/

/*
* Override the default policy for the generated machine user of this bucket.
*
user_policy = <<EOF
{
"Version": "2012-10-17",
"Statement": [
{
"Sid": "",
"Effect": "Allow",
"Action": [
"s3:GetBucketLocation"
],
"Resource": "$${bucket_arn}"
},
{
"Sid": "",
"Effect": "Allow",
"Action": [
"s3:GetObject"
],
"Resource": "$${bucket_arn}/*"
}
]
}
EOF
*/
}

Expand Down
Loading