Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spike: Ingest shared IP ranges groups / files into Ingress #6657

Closed
1 of 2 tasks
digitalali-moj opened this issue Jan 11, 2025 · 1 comment
Closed
1 of 2 tasks

Spike: Ingest shared IP ranges groups / files into Ingress #6657

digitalali-moj opened this issue Jan 11, 2025 · 1 comment

Comments

@digitalali-moj
Copy link

digitalali-moj commented Jan 11, 2025

Service name

LAA-IP-allowlist

Service environment

  • [] Dev / Development
  • [] Staging
  • Prod / Production
  • Other

Impact on the service

None

Problem description

We need a way to easily add groups of shared IP addresses into Ingress without teams duplicating effort and copying lists of IP ranges. The proposed solution is to do a spike on how we can easily pull in shared text file into Ingress without manually calling the scripts to read files. See: https://github.com/ministryofjustice/laa-ip-allowlist. The solution can also potentially be used for Pingdom ranges.

Contact person

Jav, [email protected]

@jaskaransarkaria
Copy link
Contributor

We do not offer a central solution for this it must be managed at each ingress level, similar to the method used here. If you want to prevent duplication I would encourage packaging your applications in a helm chart where you can centrally manage the IP whitelist range.

hmpps have a similar solution but instead of passing in the whitelist as a variable you could set the values for all users who use the helm chart https://github.com/ministryofjustice/hmpps-helm-charts/blob/932117a012841b1488aa7dccf6992fc815a0a1f2/charts/generic-service/templates/ingress.yaml#L18C1-L18C30

@github-project-automation github-project-automation bot moved this from Todo to 🥇 Done in Cloud Platform Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🥇 Done
Development

No branches or pull requests

3 participants