Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider changing default timezone to UTC #29

Open
martin-ballhatchet-moj opened this issue Mar 30, 2021 · 3 comments
Open

Consider changing default timezone to UTC #29

martin-ballhatchet-moj opened this issue Mar 30, 2021 · 3 comments

Comments

@martin-ballhatchet-moj
Copy link

ENV TZ=Europe/London

This may cause (has caused) issues where the local time changes and an hour goes missing or an hour repeats itself. Many such issues will be picked up by good code checking the "zone" of the time it is being passed, but not all.

@sldblog
Copy link
Contributor

sldblog commented Apr 12, 2021

Has this been discussed yet?

Edit: My primary concern is making sure the resulting images have the timezone correctly set. I had a couple of instances in MoJ where it looked like it was set to Europe/London in the Dockerfile but was in fact UTC. Of course, if all time would be timezone-aware, that wouldn't be a problem 😁

I like the "convert to local time on display" principle: if the service is doing that on the server-side, that's I think either

  1. configuration for the app, which aligns with 12-factor principles
  2. or runtime via the container timezone (we don't have any multi-region deployments, so not a big deal)

@martin-ballhatchet-moj
Copy link
Author

Nope, no discussion that I've been part of.

@sldblog
Copy link
Contributor

sldblog commented Apr 12, 2021

Where would we put an HMPPS-wide ADR (proposal) like this? 😁

I'm happy to write one with defaulting to UTC (with "make the days after the last Sunday in March and last Sunday in October free" joke suggestion 😛)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants