Update based on PR feedback

ministryofjustice · Oct 1, 2024 · d27fe37 · d27fe37
1 parent 1133b77
commit d27fe37
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 1 deletion.
diff --git a/.github/README.md b/.github/README.md
@@ -339,7 +339,7 @@ To verify that S3 & CloudFront are working correctly.
   make them available as environment variables `OAUTH_CLIENT_ID`, `OAUTH_TENANT_ID`.
 7. Click on `Certificates & secrets` > `New client secret`.
 8. Fill in the form:
-   - Description: `Staging-Intranet-v2`
+   - Description: `Staging-Intranet`
    - Expires: `18 months`
 9. Set a reminder to update the client secret before it expires.
 10. Copy the `Value` value, make it available as environment variable `OAUTH_CLIENT_SECRET`.

diff --git a/deploy/demo/config.yml b/deploy/demo/config.yml
@@ -10,5 +10,6 @@ data:
   AWS_CLOUDFRONT_HOST: 'cdn.demo.intranet.justice.gov.uk'
   SENTRY_DEV_ID: '-demo'
   # See Azure Setup for more information on how to get these values.
+  # The following IDs are not private, they form part of the publicly visible oauth login url.
   OAUTH_CLIENT_ID: "8d928bcf-c45e-41ec-aedf-059828aa6e3f"
   OAUTH_TENANT_ID: "c6874728-71e6-41fe-a9e1-2e8c36776ad8"
diff --git a/deploy/development/config.yml b/deploy/development/config.yml
@@ -9,5 +9,6 @@ data:
   WP_SITEURL: 'https://dev.intranet.justice.gov.uk/wp'
   AWS_CLOUDFRONT_HOST: 'cdn.dev.intranet.justice.gov.uk'
   # See Azure Setup for more information on how to get these values.
+  # The following IDs are not private, they form part of the publicly visible oauth login url.
   OAUTH_CLIENT_ID: "51266573-d4eb-41db-8ebe-a9548aa4f01e"
   OAUTH_TENANT_ID: "0bb413d7-160d-4839-868a-f3d46537f6af"
diff --git a/deploy/production/config.yml b/deploy/production/config.yml
@@ -9,5 +9,6 @@ data:
   WP_SITEURL: 'https://intranet.justice.gov.uk/wp'
   AWS_CLOUDFRONT_HOST: 'cdn.intranet.justice.gov.uk'
   # See Azure Setup in the README for more information on how to get these values.
+  # The following IDs are not private, they form part of the publicly visible oauth login url.
   OAUTH_CLIENT_ID: "f508fd07-8504-47ed-a7d1-aa55fd2163d1"
   OAUTH_TENANT_ID: "c6874728-71e6-41fe-a9e1-2e8c36776ad8"
diff --git a/deploy/staging/config.yml b/deploy/staging/config.yml
@@ -9,5 +9,6 @@ data:
   WP_SITEURL: 'https://staging.intranet.justice.gov.uk/wp'
   AWS_CLOUDFRONT_HOST: 'cdn.staging.intranet.justice.gov.uk'
   # See Azure Setup in the README for more information on how to get these values.
+  # The following IDs are not private, they form part of the publicly visible oauth login url.
   OAUTH_CLIENT_ID: "ffb808d2-312b-4ffe-a6e5-d6eacfd9f06f"
   OAUTH_TENANT_ID: "c6874728-71e6-41fe-a9e1-2e8c36776ad8"