Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow access to the intranet-archive via JWT. #797

Merged
merged 10 commits into from
Jan 8, 2025
Merged

Allow access to the intranet-archive via JWT. #797

merged 10 commits into from
Jan 8, 2025

Conversation

EarthlingDavey
Copy link
Contributor

@EarthlingDavey EarthlingDavey commented Nov 26, 2024 •
edited
Loading

This PR:

  • Adds a WP CLI script for manual creation of a long-lived JWT for the intranet-archive scraper.
  • Handles the newly created JWT role of intranet-archive, by allowing it access only via Cloud Platform egress IPs.

@EarthlingDavey EarthlingDavey marked this pull request as draft November 27, 2024 08:41
@EarthlingDavey EarthlingDavey marked this pull request as ready for review November 27, 2024 13:01
@EarthlingDavey EarthlingDavey changed the title Allow access to the intranet-archive user agent. Allow access to the intranet-archive via JWT. Nov 27, 2024
@EarthlingDavey EarthlingDavey mentioned this pull request Jan 3, 2025
Merged
wilson1000
wilson1000 approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@wilson1000 wilson1000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good dude 👍

@EarthlingDavey EarthlingDavey merged commit 9c6d7a2 into main Jan 8, 2025
6 checks passed
@EarthlingDavey EarthlingDavey deleted the allow-access-to-archiver branch January 8, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wilson1000 wilson1000 wilson1000 approved these changes

@EmilyHazlehurst EmilyHazlehurst Awaiting requested review from EmilyHazlehurst

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EarthlingDavey @wilson1000