Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDLS-74: CSV upload pages missing status #1477

Merged
merged 2 commits into from
Dec 4, 2023
Merged

DDLS-74: CSV upload pages missing status #1477

merged 2 commits into from
Dec 4, 2023

Conversation

Gugandeep
Copy link
Contributor

Purpose

The CSV upload pages were missing their statuses as a result of a recent change to how we use redis.
Redis keys are now stored in with the workspace (environment) name prepending the key name - environment_keyname

The setting of the keys were changed in the initial PR, however the retrieval wasn't updated along side this.

Fixes DDLS-74

Approach

Explain how your code addresses the purpose of the change

Learning

Any tips and tricks, blog posts or tools which helped you. Plus anything notable you've discovered about DigiDeps

Checklist

  • I have performed a self-review of my own code
  • I have updated documentation (Confluence/ADR/tech debt doc) where relevant
  • I have added tests to prove my work
  • The product team have approved these changes
  • I have checked my work for potential security issues and refered to the OWASP top 10

Frontend

  • I have run an in-browser accessibility test (e.g. WAVE, Lighthouse)
  • There are no deprecated CSS classes noted in the profiler
  • Translations are used and the profiler doesn't identify any missing
  • Any links or buttons added are screen reader friendly and contextually complete
  • If adding GA events, I have updated or checked the existing category or label values

@Gugandeep Gugandeep requested a review from a team as a code owner November 30, 2023 15:00
@Gugandeep Gugandeep merged commit ea6c735 into main Dec 4, 2023
36 checks passed
@Gugandeep Gugandeep deleted the DDLS-74 branch December 4, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants