From 4c42e692e8dfedb747e7ebd58a0bb48e10f39643 Mon Sep 17 00:00:00 2001
From: Mishkat Najam <mishkat.najam@digital.justice.gov.uk>
Date: Mon, 30 Oct 2023 10:20:22 +0000
Subject: [PATCH] Rename behat tests

---
 .../OneLoginAuthenticationRequestServiceTest.php            | 3 ---
 service-front/app/config/routes.php                         | 2 +-
 service-front/app/features/one-login.feature                | 6 +++---
 .../CommonTest/Service/OneLogin/OneLoginServiceTest.php     | 2 +-
 4 files changed, 5 insertions(+), 8 deletions(-)

diff --git a/service-api/app/test/AppTest/Service/Authentication/OneLoginAuthenticationRequestServiceTest.php b/service-api/app/test/AppTest/Service/Authentication/OneLoginAuthenticationRequestServiceTest.php
index c5b72cf55f..dfffef47d0 100644
--- a/service-api/app/test/AppTest/Service/Authentication/OneLoginAuthenticationRequestServiceTest.php
+++ b/service-api/app/test/AppTest/Service/Authentication/OneLoginAuthenticationRequestServiceTest.php
@@ -8,11 +8,8 @@
 use App\Service\Authentication\JWKFactory;
 use App\Service\Cache\CacheFactory;
 use App\Service\Authentication\IssuerBuilder;
-use Facile\OpenIDClient\Issuer\IssuerBuilderInterface;
 use Facile\OpenIDClient\Issuer\IssuerInterface;
 use Facile\OpenIDClient\Issuer\Metadata\IssuerMetadataInterface;
-use Facile\OpenIDClient\Issuer\Metadata\Provider\MetadataProviderBuilder;
-use Interop\Container\Containerinterface;
 use Jose\Component\Core\JWK;
 use PHPUnit\Framework\TestCase;
 use Prophecy\Argument;
diff --git a/service-front/app/config/routes.php b/service-front/app/config/routes.php
index b22132b480..0b6ba0892b 100644
--- a/service-front/app/config/routes.php
+++ b/service-front/app/config/routes.php
@@ -96,7 +96,7 @@
     $app->get('/activate-account/{token}', Actor\Handler\ActivateAccountHandler::class, 'activate-account');
 
     // User auth
-    $app->route('/login',Actor\Handler\LoginPageHandler::class, ['GET', 'POST'], 'login');
+    $app->route('/login', Actor\Handler\LoginPageHandler::class, ['GET', 'POST'], 'login');
     $app->get('/session-expired', Actor\Handler\ActorSessionExpiredHandler::class, 'session-expired');
     $app->get('/session-check', Actor\Handler\ActorSessionCheckHandler::class, 'session-check');
     $app->get('/session-refresh', Common\Handler\SessionRefreshHandler::class, 'session-refresh');
diff --git a/service-front/app/features/one-login.feature b/service-front/app/features/one-login.feature
index 1b2f10b37c..0b18d102a0 100644
--- a/service-front/app/features/one-login.feature
+++ b/service-front/app/features/one-login.feature
@@ -1,8 +1,8 @@
 @onelogin
-  Feature: Authorise One Login
+  Feature: Authenticate One Login
 
     @ui @actor @ff:allow_gov_one_login:true
-    Scenario: I initiate authorise via one login
+    Scenario: I initiate authentication via one login
       Given I am on the temporary one login page
       When I click the one login button
-      Then I am redirected to the redirect page
\ No newline at end of file
+      Then I am redirected to the redirect page
diff --git a/service-front/app/test/CommonTest/Service/OneLogin/OneLoginServiceTest.php b/service-front/app/test/CommonTest/Service/OneLogin/OneLoginServiceTest.php
index 7fd87019be..d7a8ab5625 100644
--- a/service-front/app/test/CommonTest/Service/OneLogin/OneLoginServiceTest.php
+++ b/service-front/app/test/CommonTest/Service/OneLogin/OneLoginServiceTest.php
@@ -14,7 +14,7 @@ class OneLoginServiceTest extends TestCase
     use ProphecyTrait;
 
     /** @test */
-    public function can_get_authorisation_request_uri(): void
+    public function can_get_authentication_request_uri(): void
     {
         $state = 'STATE';
         $nonce = 'aEwkamaos5B';