Merge branch 'UML-3671-findActorLpa' of github.com:ministryofjustice/…

…opg-use-an-lpa into UML-3671-findActorLpa
ministryofjustice · Nov 14, 2024 · b2467f9 · b2467f9
2 parents 61d2045 + ab07778
commit b2467f9
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/lambda-functions/upload-statistics/Dockerfile b/lambda-functions/upload-statistics/Dockerfile
@@ -6,4 +6,7 @@ COPY requirements.txt requirements.txt
 
 RUN pip install --requirement requirements.txt
 
+RUN dnf update -y libarchive --releasever 2023.6.20241028 && \
+    dnf clean all 
+
 CMD [ "upload_statistics.lambda_handler" ]
diff --git a/service-api/app/src/App/src/Service/Lpa/SiriusPerson.php b/service-api/app/src/App/src/Service/Lpa/SiriusPerson.php
@@ -39,7 +39,15 @@ public function getFirstname(): string
 
     public function getFirstnames(): string
     {
-        return trim(sprintf('%s %s', $this->person['firstname'], $this->person['middlenames']));
+        /**
+         * Although technically we should be doing
+         *
+         *     trim(sprintf('%s %s', $this->person['firstname'], $this->person['middlenames']));
+         *
+         * to produce an accurate "firstNames" field the interim object and current frontend code
+         * are not setup to handle that so we'll just return the firstname field here.
+         */
+        return $this->getFirstname();
     }
 
     public function getMiddleNames(): string