Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add readonly root filesystem #2603

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

add readonly root filesystem #2603

wants to merge 4 commits into from

Conversation

jay-whitwell
Copy link
Contributor

Purpose

Briefly describe the purpose of the change, and/or link to the JIRA ticket for context

Fixes UML-####

Approach

Explain how your code addresses the purpose of the change

Learning

Any tips and tricks, blog posts or tools which helped you. Plus anything notable you've discovered about the Use a Lasting Power of Attorney service

Checklist

  • I have performed a self-review of my own code
  • I have added relevant logging with appropriate levels to my code
  • New event_codes have been documented on the wiki page
  • I have updated documentation (Confluence/GitHub wiki/tech debt doc) where relevant
  • I have added tests to prove my work
  • I have added welsh translation tags and updated translation files
  • I have run an accessibility tool on any pages I have made changes to and fixed any issues found
  • I have notified the Interaction Designer of any content changes so that appropriate screenshots/flow diagram changes can be made
  • The product team have tested these changes

@jay-whitwell jay-whitwell requested a review from a team as a code owner May 10, 2024 10:18
@github-actions github-actions bot added the terraform Pull requests that update Terraform code label May 10, 2024
Copy link
Contributor

@cooperaj cooperaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

Think we should wait till the system message fix goes up before merging though.

@ntse ntse marked this pull request as draft May 13, 2024 09:21
@cooperaj
Copy link
Contributor

cooperaj commented Jun 7, 2024

Although it all looks to work something we should be aware of is that the the service-front apps will be writing to the /tmp folders with template caches and the like.

We could look at baking that caching process into the images maybe but it's likely to be easier to allow those images write access to /tmp.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
terraform Pull requests that update Terraform code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants