wasm lib integration using webview #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anyxem
reviewed
Mar 12, 2024
| @@ -28,7 +31,8 @@ const BlueAppComponent = () => { | |||
|
|
|||
| return ( | |||
| <BlueStorageProvider> | |||
| <App /> | |||
| {wasmInitializationFinished && <App />} | |||
| <WasmWebView setWasmInitializationFinished={setWasmInitializationFinished} /> | |||
There was a problem hiding this comment.
Please check on device that webview is not crashing because of network and non-successful wasm loading is not prevent app from loading. At least btc part have to work
There was a problem hiding this comment.
I have checked it on real device with release build.
- webview is not crashing because of network
- non-successful wasm loading is not prevent app from loading, since when webview load fails, the onLoadEnd function is also called
|
looks good, just check loaders |
anyxem
approved these changes
Mar 24, 2024
YunkevichAndrei
merged commit 2a6257f
into
feature/ml-wallet-integration
3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.