Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The "closest tr" is selected for raw_task_is and task_id as well, so you could consider reusing it. You could also consider hardening against there not being a <tr>. E.g.: #3401

Open
underdarknl opened this issue Aug 26, 2024 · 1 comment
Labels
frontend javascript Pull requests that update Javascript code

Comments

@underdarknl
Copy link
Contributor

underdarknl commented Aug 26, 2024

The "closest tr" is selected for raw_task_is and task_id as well, so you could consider reusing it. You could also consider hardening against there not being a <tr>. E.g.:

const tr = button.closest("tr");
if (!tr) return;
const raw_task_id = tr.closest("tr").getAttribute("data-task-id");
const task_id = raw_task_id.replace(/-/g, "");
const organization = organization_code || tr.getAttribute("data-organization-code");

Originally posted by @ppvg in #3389 (comment)

@underdarknl underdarknl added frontend javascript Pull requests that update Javascript code labels Aug 26, 2024
@underdarknl underdarknl added this to KAT Aug 26, 2024
@github-project-automation github-project-automation bot moved this to Incoming features / Need assessment in KAT Aug 26, 2024
@TwistMeister TwistMeister removed their assignment Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend javascript Pull requests that update Javascript code
Projects
Status: Incoming features / Need assessment
Development

No branches or pull requests

3 participants
@underdarknl @TwistMeister and others