Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generic container for non-docker local boefjes #3698

Open
4 tasks done
Donnype opened this issue Oct 17, 2024 · 1 comment · May be fixed by #3859
Open
4 tasks done

Generic container for non-docker local boefjes #3698

Donnype opened this issue Oct 17, 2024 · 1 comment · May be fixed by #3859
Assignees
@noamblitz @Donnype
Labels
boefjes Issues related to boefjes

Comments

@Donnype
Copy link
Contributor

Donnype commented Oct 17, 2024 •
edited
Loading

Blocked by: #3861
Subticket of #3593.

TODO

  • Create a generic image and adapter that handles the oci_arguments being the path to the targeted module
  • Rewrite all non-docker local boefjes by making the run() method accept a dict and hence drop the BoefjeMeta type hint as well. Also we need to add the requirements.txt back in the boefje directory.
  • Drop the requirements that are not needed anymore from the boefjes pyproject.toml
  • Create migration for boefjes in the boefje table: changing the boefjes.json for static boefjes means the db is out of sync for entries for that boefje. We need to either keep these aligned or make sure we ignore the fields for static database entries. -> we should ignore the database entries for the time being
@Donnype Donnype added this to KAT Oct 17, 2024
@Donnype Donnype converted this from a draft issue Oct 17, 2024
@Donnype Donnype added the boefjes Issues related to boefjes label Oct 17, 2024
@Donnype Donnype mentioned this issue Oct 17, 2024
Open
3 tasks
@Donnype
Copy link
Contributor Author

Donnype commented Oct 23, 2024 •
edited
Loading

Screenshots of a working cache:

Image

After running RPKI succesfully, running the container with the same volume mount shows us the filled cache:
Image

EDIT: now namespaced on boefje_id:
Image

@Donnype Donnype changed the title Generic container for local boefjes Generic container for non-docker local boefjes Nov 19, 2024
@Donnype Donnype linked a pull request Nov 19, 2024 that will close this issue
Draft
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@noamblitz noamblitz

@Donnype Donnype

Labels
boefjes Issues related to boefjes
Projects
KAT
Status: Blocked
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Containerize all non-docker boefjes minvws/nl-kat-coordination
2 participants
@noamblitz @Donnype