Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Salt script broken #200

Closed
palainp opened this issue Aug 10, 2024 · 2 comments
Closed

Salt script broken #200

palainp opened this issue Aug 10, 2024 · 2 comments

Comments

@palainp
Copy link
Member

palainp commented Aug 10, 2024

As initramfs is no longer needed (see #70) we will be able to release only the unikernel file. With that in mind, the salt script can be simplified (no more tar involved) and, in the process, we can try to check the hashsum against something other than the one in the build script (maybe the best option would be to ship a hashsum file along the unikernel file?).

This will allow PRs to be merged (like #199) without needing for an immediate release matching the hashsum (and that explains this issue's title :) ).

@palainp
Copy link
Member Author

palainp commented Oct 16, 2024

While preparing the next release, I wonder if a possible solution would be to have:

  • a qubes-firewall.sha256 file containing the hashsum of the current head (the one used in GH actions)
  • a qubes-firewall-release.sha256 file containing the hashsum of the latest release (the one used in the salt script)
  • releases files will contain vmlinuz and qubes-firewall-release.sha256

Does anyone have a idea about that?

@palainp
Copy link
Member Author

palainp commented Oct 17, 2024

Done (or will be done) in #205

@palainp palainp closed this as completed Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant