fix(app/docker): rename distro to Docker Desktop #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taoky
reviewed
Jan 20, 2025
| [docker win] | ||
| distro = Docker | ||
| [docker desktop win] | ||
| distro = Docker Desktop |
taoky
reviewed
Jan 20, 2025
| [docker mac] | ||
| distro = Docker | ||
| [docker desktop mac] | ||
| distro = Docker Desktop |
|
可能应该改叫 Docker client（macOS）和 Docker Windows container server and client（Windows）？但是绝对不是 Docker Desktop，这是个有商业授权限制的私有软件，不应该出现在 docker-ce 里面。 |
|
抱歉脑抽了，看到单个文件 + 仅 Windows + macOS 就以为是 Desktop 是否可以讨论下更好的文案，避免被认为是 Desktop？官方页面对此没有单独的称呼 https://docs.docker.com/engine/install/，也许可以将 distro 改为 Docker Engine |
|
对应的应该是这个页面：https://docs.docker.com/engine/install/binaries/ 但是这么看感觉对应的用途实在太偏门了，Windows 和 macOS 上想跑 Docker 的应该要的绝大部分都不是这个。我在想是否应该整个删掉。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.