Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update @lezer/common and @lezer/lr #1

Closed
joegar000 opened this issue Dec 7, 2022 · 5 comments
Closed

Update @lezer/common and @lezer/lr #1

joegar000 opened this issue Dec 7, 2022 · 5 comments

Comments

@joegar000
Copy link

I'm working on a project that utilizes both the CodeMirror editor and Parcel. Since both CodeMirror and Parcel utilize the lezer parser system, Parcel's older version of @lezer/common is conflicting with the current version of @lezer/common that I need for my project. Any help is appreciated, thanks!

@karlhorky
Copy link

@mischnic what do you think about upgrading to ^1.0.0 of both @lezer/common and @lezer/lr and then releasing as a patch version?

This would allow people with existing transitive dependencies to upgrade without other depending packages having to release new versions...

@karlhorky
Copy link

karlhorky commented Sep 20, 2023

@mischnic To be clear about the problem, if other packages such as CodeMirror use modern versions of @lezer/common and @lezer/lr, then things like syntax highlighting will break, as mentioned below (which is a problem that can easily make it to production without someone noticing):

There are workarounds with Yarn Resolutions or npm/pnpm Overrides mentioned in the issues above, but it would be great if @mischnic/json-sourcemap used a modern version of @lezer/common and @lezer/lr out of the box.

@mischnic
Copy link
Owner

mischnic commented Sep 20, 2023

I'll try to do this soon. Last time I tried I ran into some problems when upgrading https://github.com/mischnic/parcel-transformer-lezer (used here to build this package) to use lezer 1.x

@mischnic
Copy link
Owner

0.1.1 is published, let's hope I didn't break anything.

@karlhorky
Copy link

Running the updated version in production now (via @parcel/core via gatsby), no complaints yet :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants