Skip to content
This repository has been archived by the owner on Feb 15, 2025. It is now read-only.

24w10a #52

Merged
merged 10 commits into from
Mar 6, 2024
Merged

24w10a #52

merged 10 commits into from
Mar 6, 2024

Conversation

Apollounknowndev
Copy link
Contributor

@Apollounknowndev Apollounknowndev commented Mar 6, 2024

Todo:

  • Banner patterns
  • Wolf variants
  • Components in recipes
  • Misc. item component changes
  • Slot predicate

Optional profile name, firework/lore max increase, lodestone tracker
Copy link
Owner

@misode misode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't comment on Components yet

@Apollounknowndev
Copy link
Contributor Author

That should be all of the component changes, just remembered the slot field was added so I'll work on that next and that should be everything

@Apollounknowndev
Copy link
Contributor Author

Since there are so many possible slot values (161 total I think?), I currently have the keys for the slot field accept any string but have the collection slots (container.*, enderchest.*, etc.) suggested by default. Might not be the best solution, I can change it if needed.

@Apollounknowndev Apollounknowndev marked this pull request as ready for review March 6, 2024 18:53
@Apollounknowndev Apollounknowndev requested a review from misode March 6, 2024 19:09
Copy link
Owner

@misode misode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this!

@misode misode merged commit 9720e86 into misode:master Mar 6, 2024
1 check failed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants