Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add endian configuration to support Bedrock Edition #45

Open
hhhxiao opened this issue Mar 31, 2023 · 1 comment
Open

Add endian configuration to support Bedrock Edition #45

hhhxiao opened this issue Mar 31, 2023 · 1 comment
Labels
feature New feature or request

Comments

@hhhxiao
Copy link

hhhxiao commented Mar 31, 2023

The Java version and the Bedrock version have different endianness when parse NBT format, and the Bedrock version is little-endian in the disk, but I noticed that in
https://github.com/misode/vscode-nbt/blob/5cac73104c2453aa885acb1c819c4f07e3702ba1/src/NbtDocument.ts#LL41C14-L41C14

The endianness is hard-coded to read in little-endian only if the file extension is .mcstructure.
Therefore I suggest that a configurable option can be added to override this value to support Bedrock Edition.
(This change will not affect developers of the java version)

@misode misode added the feature New feature or request label Jun 18, 2023
@misode
Copy link
Owner

misode commented Nov 20, 2023

@hhhxiao I believe this was fixed together with #52 in version 0.8.2. Could you confirm whether this issue still exists?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants