Clean-up linting

Signed-off-by: Sam Stuewe <[email protected]>

Author: HalosGhost

src/uhs/transaction/transaction.cpp

@@ -252,8 +252,7 @@ namespace cbdc::transaction {
                secp256k1_bulletproofs_generators* gens,
                random_source& rng,
                const spend_data& out_spend_data,
-               const secp256k1_pedersen_commitment* comm)
-        -> rangeproof_t<> {
+               const secp256k1_pedersen_commitment* comm) -> rangeproof_t<> {
         rangeproof_t<> range{};
         size_t rangelen = range.size();
         static constexpr auto upper_bound = 64; // 2^64 - 1

src/uhs/transaction/transaction.hpp

@@ -58,8 +58,8 @@ namespace cbdc::transaction {
         /// An auxiliary value used to prove preservation of balance
         commitment_t m_auxiliary{};
         /// The rangeproof guaranteeing that the output is greater than 0
-        /// This rangeproof is only required when functioning as a transaction output,
-        /// and is removed when converted into a transaction input.
+        /// This rangeproof is only required when functioning as a transaction
+        /// output, and is removed when converted into a transaction input.
         std::optional<rangeproof_t<>> m_range{};
 
         auto operator==(const output& rhs) const -> bool;
@@ -78,8 +78,9 @@ namespace cbdc::transaction {
     ///              output to-be-spent
     /// \param put the \ref output to-be-spent
     /// \returns the hash serving as the UHS ID
-    auto calculate_uhs_id(const out_point& point, const output& put, const commitment_t& value)
-        -> hash_t;
+    auto calculate_uhs_id(const out_point& point,
+                          const output& put,
+                          const commitment_t& value) -> hash_t;
 
     /// \brief Additional information a spender needs to spend an input
     struct spend_data {
@@ -259,8 +260,7 @@ namespace cbdc::transaction {
                secp256k1_bulletproofs_generators* gens,
                random_source& rng,
                const spend_data& out_spend_data,
-               const secp256k1_pedersen_commitment* comm)
-        -> rangeproof_t<>;
+               const secp256k1_pedersen_commitment* comm) -> rangeproof_t<>;
 
     /// \brief Add cryptographic proof to a single output
     ///

src/uhs/transaction/validation.cpp

@@ -253,7 +253,7 @@ namespace cbdc::transaction::validation {
         }
         return std::nullopt;
     }
-    
+
     auto check_witness_count(const cbdc::transaction::full_tx& tx)
         -> std::optional<tx_error> {
         if(tx.m_inputs.size() != tx.m_witness.size()) {

src/uhs/transaction/validation.hpp

@@ -169,7 +169,7 @@ namespace cbdc::transaction::validation {
     auto check_input_set(const transaction::full_tx& tx)
         -> std::optional<tx_error>;
     auto check_proof(const compact_tx& tx,
-                     const std::vector<commitment_t>& inp_comms)
+                     const std::vector<commitment_t>& inps)
         -> std::optional<proof_error>;
     auto check_commitment_sum(
         const std::vector<secp256k1_pedersen_commitment>& inputs,

src/uhs/transaction/wallet.cpp

@@ -62,7 +62,7 @@ namespace cbdc {
             std::unique_lock<std::shared_mutex> ul(m_utxos_mut);
             for(size_t i = 0; i < ret.m_outputs.size(); ++i) {
                 transaction::output put = ret.m_outputs[i];
-                put.m_range.reset();   // remove range proofs for inputs
+                put.m_range.reset(); // remove range proofs for inputs
                 transaction::out_point point{id, i};
                 transaction::input inp{point,
                                        put,
@@ -127,9 +127,11 @@ namespace cbdc {
         return ret;
     }
 
-    auto transaction::wallet::create_seeded_transaction(size_t seed_idx,
-        const commitment_t& comm,
-        const rangeproof_t<>& range) -> std::optional<transaction::full_tx> {
+    auto
+    transaction::wallet::create_seeded_transaction(size_t seed_idx,
+                                                   const commitment_t& comm,
+                                                   const rangeproof_t<>& range)
+        -> std::optional<transaction::full_tx> {
         if(m_seed_from == m_seed_to) {
             return std::nullopt;
         }
@@ -147,7 +149,8 @@ namespace cbdc {
         inp.m_prevout_data.m_witness_program_commitment = {0};
         inp.m_prevout_data.m_auxiliary = comm;
         inp.m_prevout_data.m_range.reset();
-        inp.m_prevout_data.m_id = calculate_uhs_id(inp.m_prevout, inp.m_prevout_data, comm);
+        inp.m_prevout_data.m_id
+            = calculate_uhs_id(inp.m_prevout, inp.m_prevout_data, comm);
         inp.m_spend_data = {spend};
 
         tx.m_inputs[0] = inp;
@@ -188,7 +191,8 @@ namespace cbdc {
                                                  {},
                                                  in_spend_data);
 
-        inp.m_prevout_data.m_auxiliary = serialize_commitment(m_secp.get(), aux.front());
+        inp.m_prevout_data.m_auxiliary
+            = serialize_commitment(m_secp.get(), aux.front());
         inp.m_prevout_data.m_id
             = transaction::calculate_uhs_id(inp.m_prevout,
                                             inp.m_prevout_data,

src/uhs/transaction/wallet.hpp

@@ -227,8 +227,9 @@ namespace cbdc::transaction {
 
         /// \brief todo: document overload
         auto create_seeded_transaction(size_t seed_idx,
-            const commitment_t& comm,
-            const rangeproof_t<>& range) -> std::optional<transaction::full_tx>;
+                                       const commitment_t& comm,
+                                       const rangeproof_t<>& range)
+            -> std::optional<transaction::full_tx>;
 
         /// Given a set of credit inputs, add the UTXOs and update the wallet's
         /// balance.

tests/unit/atomizer_test.cpp

@@ -52,7 +52,7 @@ TEST_F(atomizer_test, test_with_transactions) {
             cbdc::transaction::output out;
             out.m_witness_program_commitment = {val++};
             out.m_range = cbdc::rangeproof_t<>{'\0'};
-            
+
             tx.m_inputs.push_back(inp);
             tx.m_outputs.push_back(out);
 

tests/unit/message_test.cpp

@@ -465,7 +465,10 @@ TEST_F(PacketIOTest, aggregate_tx_notify_request) {
 
 TEST_F(PacketIOTest, variant) {
     auto outpoint = cbdc::transaction::out_point{{'a', 'b', 'c', 'd'}, 1};
-    auto output = cbdc::transaction::output{{'b'}, {'c'}, {'d'}, cbdc::rangeproof_t<>{'e'}};
+    auto output = cbdc::transaction::output{{'b'},
+                                            {'c'},
+                                            {'d'},
+                                            cbdc::rangeproof_t<>{'e'}};
     auto var = std::variant<cbdc::transaction::out_point,
                             cbdc::transaction::output>(outpoint);
     m_ser << var;

tools/shard-seeder/shard-seeder.cpp

@@ -7,8 +7,8 @@
 #include "uhs/transaction/transaction.hpp"
 #include "uhs/transaction/validation.hpp"
 #include "uhs/transaction/wallet.hpp"
-#include "util/common/config.hpp"
 #include "util/common/commitment.hpp"
+#include "util/common/config.hpp"
 #include "util/serialization/buffer_serializer.hpp"
 #include "util/serialization/format.hpp"
 #include "util/serialization/ostream_serializer.hpp"
@@ -150,16 +150,24 @@ auto main(int argc, char** argv) -> int {
                     }
                     auto batch_size = 0;
                     leveldb::WriteBatch batch;
-                    auto value = cbdc::commit(secp_context.get(), cfg.m_seed_value, {}).value();
-                    auto range = cbdc::transaction::prove(secp_context.get(),
-                                                          bulletproof_gens.get(),
-                                                          rng,
-                                                          {{}, cfg.m_seed_value},
-                                                          &value);
-                    auto value_comm = cbdc::serialize_commitment(secp_context.get(), value);
+                    auto value = cbdc::commit(secp_context.get(),
+                                              cfg.m_seed_value,
+                                              {})
+                                     .value();
+                    auto range
+                        = cbdc::transaction::prove(secp_context.get(),
+                                                   bulletproof_gens.get(),
+                                                   rng,
+                                                   {{}, cfg.m_seed_value},
+                                                   &value);
+                    auto value_comm
+                        = cbdc::serialize_commitment(secp_context.get(),
+                                                     value);
                     for(size_t tx_idx = 0; tx_idx != num_utxos; tx_idx++) {
-                        auto tx
-                            = wal.create_seeded_transaction(tx_idx, value_comm, range).value();
+                        auto tx = wal.create_seeded_transaction(tx_idx,
+                                                                value_comm,
+                                                                range)
+                                      .value();
                         cbdc::transaction::compact_tx ctx(tx);
                         const cbdc::hash_t& output_hash
                             = cbdc::transaction::calculate_uhs_id(