New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

why `max_gen_len` is needed when considering `space_needed`? #78

Open

Mr-lonely0 opened this issue Mar 29, 2024 · 1 comment

Mr-lonely0 commented Mar 29, 2024

Thank you for your time, here are my questions:

I wonder why cache_size is updated only at every turn rather than every decoding step.
When considering space needed in cache, why max_gen_len is needed to include

zhenghuawang6 commented Jan 4, 2025

This is also my concern. I think the cache should be updated after every decoding stage!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment