Upload standalone binaries to release pages #1711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JasonGross
force-pushed
the
standalone-package-extra
branch
8 times, most recently
from
1c17c57
to
6a2a105
Compare
JasonGross
changed the title
JasonGross
force-pushed
the
standalone-package-extra
branch
from
6a2a105
to
d755d93
Compare
JasonGross
force-pushed
the
standalone-package-extra
branch
5 times, most recently
from
bcd259a
to
efce731
Compare
JasonGross
force-pushed
the
standalone-package-extra
branch
from
efce731
to
6517698
Compare
JasonGross
force-pushed
the
standalone-package-extra
branch
2 times, most recently
from
2c57844
to
51546c5
Compare
JasonGross
force-pushed
the
standalone-package-extra
branch
from
51546c5
to
f64af12
Compare
|
Only dumpbin fails, I'm going to merge this and then fix it immediately after, I don't want to bother with another round of CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's also some minimal testing to see that the binaries work without installing all the extra Coq infrastructure.
Presumably we should get #1625 working and upload only statically-linked elf binaries (+ mac & windows), not separate binaries for docker, debian, etc. Also TODO: figuring out if we need to do extra things to get Windows binaries working (probably?).
On top of #1710