Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTPS is downgraded to HTTP by default #25

Open
AnyOldName3 opened this issue Jan 18, 2024 · 2 comments
Open

HTTPS is downgraded to HTTP by default #25

AnyOldName3 opened this issue Jan 18, 2024 · 2 comments

Comments

@AnyOldName3
Copy link

This is a regression compared to the upstream 3.49.2 release that binaries are provided for. This is caused by #9

I've not set an HTTPS proxy or checked the checkbox to use the proxy for HTTPS, but opt->https_proxy ends up true anyway, and so https://github.com/mitchcapper/httrack/pull/9/files#diff-3df488ec9336b33abf71a0a722dbcb55bc19212fb2d082ce2ef68376b0a8281bR1958 means I don't get HTTPS at all.

I think it's getting forcibly enabled because https://github.com/mitchcapper/httrack-windows/blob/master/WinHTTrack/Shell.cpp#L2480-L2481

		MyWriteProfileInt(path, strSection, "UseHTTPProxyForFTP", maintab->m_option10.m_ftpprox);
		MyWriteProfileInt(path, strSection, "UseHTTPProxyForHTTPS", maintab->m_option10.m_ftpprox);

should instead be

		MyWriteProfileInt(path, strSection, "UseHTTPProxyForFTP", maintab->m_option10.m_ftpprox);
		MyWriteProfileInt(path, strSection, "UseHTTPProxyForHTTPS", maintab->m_option10.m_sslproxy);

but I'm not 100% sure what the intended behaviour is - maybe that's not a fix on its own and it's sensible to disable opt->https_proxy unless there's actually a proxy specified.

@AnyOldName3
Copy link
Author

maintab->m_option10.m_sslproxy = MyGetProfileInt(path, strSection, "UseHTTPProxyForHTTPS", 1);

needs to happen, too.

@AnyOldName3
Copy link
Author

fix-https-proxy-ini-access.patch

That's the above changes in a patch file in case anyone needs it. That at least means the setting you set gets remembered and respected. I'm still unconvinced it's a good idea for the setting to default to being on when there's no proxy set up (or at least that it ends up still downgrading to plain HTTP when there's no proxy).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant