You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
but I'm not 100% sure what the intended behaviour is - maybe that's not a fix on its own and it's sensible to disable opt->https_proxy unless there's actually a proxy specified.
The text was updated successfully, but these errors were encountered:
That's the above changes in a patch file in case anyone needs it. That at least means the setting you set gets remembered and respected. I'm still unconvinced it's a good idea for the setting to default to being on when there's no proxy set up (or at least that it ends up still downgrading to plain HTTP when there's no proxy).
This is a regression compared to the upstream 3.49.2 release that binaries are provided for. This is caused by #9
I've not set an HTTPS proxy or checked the checkbox to use the proxy for HTTPS, but
opt->https_proxy
ends up true anyway, and so https://github.com/mitchcapper/httrack/pull/9/files#diff-3df488ec9336b33abf71a0a722dbcb55bc19212fb2d082ce2ef68376b0a8281bR1958 means I don't get HTTPS at all.I think it's getting forcibly enabled because https://github.com/mitchcapper/httrack-windows/blob/master/WinHTTrack/Shell.cpp#L2480-L2481
should instead be
but I'm not 100% sure what the intended behaviour is - maybe that's not a fix on its own and it's sensible to disable
opt->https_proxy
unless there's actually a proxy specified.The text was updated successfully, but these errors were encountered: