Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump minimal ruby version to 2.7 and run tests in GitHub Actions #2

Merged
merged 1 commit into from
Sep 27, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions .github/workflows/ruby.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
name: Ruby

on:
push:
branches:
- main
pull_request:

jobs:
test:
runs-on: ubuntu-latest
strategy:
matrix:
ruby-version: ['2.7', '3.0', '3.1', '3.2']

steps:
- uses: actions/checkout@v4
- name: Set up Ruby
uses: ruby/setup-ruby@v1
with:
ruby-version: ${{ matrix.ruby-version }}
bundler-cache: true # runs 'bundle install' and caches installed gems automatically
- name: Run tests
run: bundle exec rspec
7 changes: 0 additions & 7 deletions .travis.yml

This file was deleted.

5 changes: 1 addition & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,7 @@

Omniauth strategy for using Swedbank as an authentication service provider.

[![Gem Version](https://badge.fury.io/rb/omniauth-swedbank.png)](http://badge.fury.io/rb/omniauth-swedbank)
[![Build Status](https://travis-ci.org/mitigate-dev/omniauth-swedbank.svg?branch=master)](https://travis-ci.org/mitigate-dev/omniauth-swedbank)

Supported Ruby versions: 2.2+
Supported Ruby versions: 2.7+

## Related projects

Expand Down
5 changes: 3 additions & 2 deletions omniauth-swedbank.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,15 @@ Gem::Specification.new do |spec|
spec.test_files = spec.files.grep(%r{^(test|spec|features)/})
spec.require_paths = ['lib']

spec.required_ruby_version = '>= 2.2.2'
spec.required_ruby_version = '>= 2.7'

spec.add_runtime_dependency 'omniauth', '~> 2.1'
spec.add_runtime_dependency 'i18n'

spec.add_development_dependency 'rack', '~> 2.0'
spec.add_development_dependency 'rack'
spec.add_development_dependency 'rack-test'
spec.add_development_dependency 'rspec'
spec.add_development_dependency 'bundler'
spec.add_development_dependency 'rake'
spec.add_development_dependency 'rack-session'
end
9 changes: 5 additions & 4 deletions spec/omniauth/strategies/swedbank_spec.rb
Original file line number Diff line number Diff line change
@@ -1,13 +1,14 @@
require 'spec_helper'
require 'rack-protection'
require 'rack/session'

describe OmniAuth::Strategies::Swedbank do

PRIVATE_KEY = File.read(File.join(RSpec.configuration.cert_folder, 'request.private.pem'))
PUBLIC_KEY = File.read(File.join(RSpec.configuration.cert_folder, 'response.public.pem'))

let(:app){ Rack::Builder.new do |b|
b.use Rack::Session::Cookie, {secret: 'abc123'}
b.use Rack::Session::Cookie, {secret: '5242e6bd9daf0e9645c2d4e22b11ba8cee0bed44439906d5f1bd5dad409d8637'}
b.use(OmniAuth::Strategies::Swedbank, PRIVATE_KEY, PUBLIC_KEY, 'MY_SND_ID', 'MY_REC_ID')
b.run lambda{|env| [404, {}, ['Not Found']]}
end.to_app }
Expand Down Expand Up @@ -81,7 +82,7 @@

context 'with custom options' do
let(:app){ Rack::Builder.new do |b|
b.use Rack::Session::Cookie, {secret: 'abc123'}
b.use Rack::Session::Cookie, {secret: '5242e6bd9daf0e9645c2d4e22b11ba8cee0bed44439906d5f1bd5dad409d8637'}
b.use(OmniAuth::Strategies::Swedbank, PRIVATE_KEY, PUBLIC_KEY, 'MY_SND_ID', 'MY_REC_ID',
site: 'https://test.lv/banklink')
b.run lambda{|env| [404, {}, ['Not Found']]}
Expand All @@ -94,7 +95,7 @@

context 'with non-existant private key files' do
let(:app){ Rack::Builder.new do |b|
b.use Rack::Session::Cookie, {secret: 'abc123'}
b.use Rack::Session::Cookie, {secret: '5242e6bd9daf0e9645c2d4e22b11ba8cee0bed44439906d5f1bd5dad409d8637'}
b.use(OmniAuth::Strategies::Swedbank, 'missing-private-key-file.pem', PUBLIC_KEY, 'MY_SND_ID', 'MY_REC_ID')
b.run lambda{|env| [404, {}, ['Not Found']]}
end.to_app }
Expand Down Expand Up @@ -134,7 +135,7 @@

context 'with non-existant public key file' do
let(:app){ Rack::Builder.new do |b|
b.use Rack::Session::Cookie, {secret: 'abc123'}
b.use Rack::Session::Cookie, {secret: '5242e6bd9daf0e9645c2d4e22b11ba8cee0bed44439906d5f1bd5dad409d8637'}
b.use(OmniAuth::Strategies::Swedbank, PRIVATE_KEY, 'missing-public-key-file.pem', 'MY_SND_ID', 'MY_REC_ID')
b.run lambda{|env| [404, {}, ['Not Found']]}
end.to_app }
Expand Down