Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make edx-platform log configurable #269

Open
pdpinch opened this issue Jul 19, 2021 · 1 comment
Open

make edx-platform log configurable #269

pdpinch opened this issue Jul 19, 2021 · 1 comment

Comments

@pdpinch
Copy link
Member

pdpinch commented Jul 19, 2021

As a devops/sre, I'd like to be able to configure the logging format, structure and potentially add new log handlers by passing configuration to the log function at https://github.com/edx/edx-platform/blob/master/openedx/core/lib/logsettings.py#L13

It would be beneficial to expose more customizability to how the logging is set up. For instance, either make this function more flexible, so that it can accept a dict_config that gets merged with the one inside the function, or moving the log configuration into the settings module so that it can be managed in the same way as the other configuration values.

acceptance criteria

  • write an ADR describing the approach and open a PR upstream in edx-platform for it
  • when there is consensus about the approach merge the ADR and open another PR with the implementation.
@pdpinch
Copy link
Member Author

pdpinch commented Apr 18, 2023

Is this still needed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants