Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Kosovo as an independent country to profile #4283

Closed
pdpinch opened this issue Mar 14, 2019 · 3 comments · Fixed by mitodl/iso-3166-2.js#2 or #4314
Closed

Add Kosovo as an independent country to profile #4283

pdpinch opened this issue Mar 14, 2019 · 3 comments · Fixed by mitodl/iso-3166-2.js#2 or #4314
Assignees
@tasawernawaz
Milestone
05/13/2019

Comments

@pdpinch
Copy link
Member

pdpinch commented Mar 14, 2019

ZenDesk ticket at https://odl.zendesk.com/agent/tickets/26911

blog post on ISO use of XK: https://geonames.wordpress.com/2010/03/08/xk-country-code-for-kosovo/

We'll need to fork https://github.com/olahol/iso-3166-2.js (again), but they do seem to accept PRs.
@tasawernawaz tasawernawaz mentioned this issue Apr 17, 2019
Merged
@pdpinch
Copy link
Member Author

pdpinch commented Apr 26, 2019

We need to update micromasters to user our fork of iso-3166-2.js, mitodl/iso-3166-2.js@36ef643

Also, @tasawernawaz you should open up a PR upstream to iso-3166-2.js

@pdpinch pdpinch reopened this Apr 26, 2019
@tasawernawaz tasawernawaz mentioned this issue Apr 29, 2019
Merged
@pdpinch
Copy link
Member Author

pdpinch commented May 2, 2019

@tasawernawaz Can you add a link here to the upstream PR?

@pdpinch pdpinch added this to the 05/13/2019 milestone May 3, 2019
@tasawernawaz
Copy link

@pdpinch Link to upstream PR: olahol/iso-3166-2.js#27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tasawernawaz tasawernawaz

Labels
None yet
Projects
None yet
Milestone
05/13/2019
2 participants
@pdpinch @tasawernawaz