Update proxmox-via-prometheus.json #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I made some adjustments to cover a cluster. Actually, Display Name overrides and some query tweaks for the single nodes, see attached screenshot. I don't seem to be able to properly change the label of the storage bar char (showing all of the storages of all the three nodes) The labels now are as follow: "pve monitoring pve-cluster Ceph-NVMe2TB"
0xErnie
reviewed
Oct 27, 2023
| } | ||
| ] | ||
| } | ||
| ] |
There was a problem hiding this comment.
It looks to me that the overrides you added will only be working for a cluster of three nodes named pvenode1-3. You may want to remove those from the pull request, since they are not universal to every proxmox cluster.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made some adjustments to cover a cluster.
Actually, Display Name overrides and some query tweaks for the single nodes, see attached screenshot.
I don't seem to be able to properly change the label of the storage bar char (showing all of the storages of all the three nodes) The labels now are as follow:
"pve monitoring pve-cluster Ceph-NVMe2TB"