Merge pull request DOCGroup#2196 from mitza-oci/ace6-cdrfixed

[ACE 6] Avoid potential out-of-bounds read in ACE_CDR::Fixed::from_string
mitza-oci · Feb 9, 2024 · 1abcd01 · 1abcd01
2 parents a5aa839 + 794ab90
commit 1abcd01
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/ACE/ace/CDR_Base.cpp b/ACE/ace/CDR_Base.cpp
@@ -935,7 +935,7 @@ ACE_CDR::Fixed ACE_CDR::Fixed::from_string (const char *str)
       ++f.digits_;
     }
 
-  if (!f.scale_ && str[span - f.digits_ - 1] == '.')
+  if (!f.scale_ && span > f.digits_ && str[span - f.digits_ - 1] == '.')
     f.scale_ = f.digits_;
 
   if (idx >= 0)