Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logic of parsing values with commas is flawed #8

Open
afterlogic-support opened this issue Jul 18, 2018 · 0 comments
Open

Logic of parsing values with commas is flawed #8

afterlogic-support opened this issue Jul 18, 2018 · 0 comments

Comments

@afterlogic-support
Copy link

The way the code is written makes it impossible to preserve commas in comma-separated lists.

For instance, if we have this:

 CATEGORIES:Home\,Sport,Group

After parsing we should have two categories: "Home,Sport" and "Group". But we end up with three: "Home", "Sport", "Group". And the code is written the way which makes it hardly possible to quick-fix this. The code first eliminates escaping in tokenizer (so that you'll have "Home,Sport,Group" down the code) and then splits it by individual tokens and so on.

It does not make any difference between tokens which are just text and which are comma-separated lists (like CATEGORIES). So, "\," and "," become equivalent after Sanitizer.UnEscape processing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant