From 490ed1967e1368dcdd2df210dbd7127391a49c9c Mon Sep 17 00:00:00 2001 From: JoergAtGithub <64457745+JoergAtGithub@users.noreply.github.com> Date: Mon, 11 Nov 2024 19:35:38 +0100 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Swiftb0y <12380386+Swiftb0y@users.noreply.github.com> --- src/engine/controls/macrocontrol.cpp | 2 +- src/track/macro.cpp | 2 +- src/track/macroaction.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/engine/controls/macrocontrol.cpp b/src/engine/controls/macrocontrol.cpp index 98d42c5d77b..30d0f537c95 100644 --- a/src/engine/controls/macrocontrol.cpp +++ b/src/engine/controls/macrocontrol.cpp @@ -15,7 +15,7 @@ const QRegExp kAutoGeneratedLabelRegExp(QStringLiteral("[0-9. ]+(\\[\\w*\\])?")) } // namespace ConfigKey MacroControl::getConfigKey(const QString& name) { - return ConfigKey(m_group, QStringLiteral("macro_%1_%2").arg(m_slot).arg(name)); + return ConfigKey(m_group, QStringLiteral("macro_%1_%2").arg(m_slot, name)); } MacroControl::MacroControl(const QString& group, UserSettingsPointer pConfig, int slot) diff --git a/src/track/macro.cpp b/src/track/macro.cpp index 5652f69aa40..a9036c65bbb 100644 --- a/src/track/macro.cpp +++ b/src/track/macro.cpp @@ -95,7 +95,7 @@ void Macro::addAction(const MacroAction& action) { mixxx::audio::FramePos Macro::getStart() const { VERIFY_OR_DEBUG_ASSERT(!getActions().isEmpty()) { - return mixxx::audio::FramePos(0); + return mixxx::audio::FramePos(); } return m_actions.first().getTargetPosition(); } diff --git a/src/track/macroaction.h b/src/track/macroaction.h index bf10b087a16..a7ae6c5dcdc 100644 --- a/src/track/macroaction.h +++ b/src/track/macroaction.h @@ -12,7 +12,7 @@ namespace proto = mixxx::track::io; /// but that is subject to change. class MacroAction { public: - enum class Type : uint32_t { + enum class Type { Jump = 0 };