Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make Beatjump use seconds if no beatgrid is detected #11124

Closed
ronso0 opened this issue Dec 12, 2022 · 2 comments · Fixed by #12961
Closed

make Beatjump use seconds if no beatgrid is detected #11124

ronso0 opened this issue Dec 12, 2022 · 2 comments · Fixed by #12961

Comments

@ronso0
Copy link
Member

ronso0 commented Dec 12, 2022

Feature Description

Make Beatjump controls switch from beats to seconds if no beatgrid is detected so these controls are of some use at least.
This is useful for beat-less tracks as well as jumping in long tracks while they're being analyzed.

  • the beatjump size spinbox could show the s suffix
  • I guess making the loop engine deal with seconds is too much hazzle, so the beatloop size spinbox and the loop activate button (with no saved loop) should probably be greyed out
@ronso0
Copy link
Member Author

ronso0 commented Mar 13, 2024

Alternative:
if track has no beats, use fake beats (100 BPM?)

@ronso0
Copy link
Member Author

ronso0 commented Aug 31, 2024

Fixed in #12961

@ronso0 ronso0 closed this as completed Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants