Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No way to directly (Wizard) map waveform_zoom to a controller pot yet #12251

Open
mxmilkiib opened this issue Nov 3, 2023 · 10 comments · May be fixed by #12387
Open

No way to directly (Wizard) map waveform_zoom to a controller pot yet #12251

mxmilkiib opened this issue Nov 3, 2023 · 10 comments · May be fixed by #12387

Comments

@mxmilkiib
Copy link
Contributor

See note here; https://mixxx.discourse.group/t/waveform-zoom-midi-control-on-a-cc-dial/28293/5

@ronso0 ronso0 linked a pull request Dec 4, 2023 that will close this issue
1 task
@ronso0
Copy link
Member

ronso0 commented Dec 4, 2023

here it is #12387

@mxmilkiib
Copy link
Contributor Author

Totally forgot about all this ;o Thanks!

I'm back trying to map things to a controller again, and I got to "mapping 'Waveform Zoom' to an encoder does nothing" again.

Maybe, if this would be easy enough given how far it has gotten already, this could be one for the 2.5 feature list (re Zulip discussion)?

@ronso0
Copy link
Member

ronso0 commented Feb 22, 2024

#12387 is already on the 2.5 milestone.
Did you test that? Incl. mapping an encoder to the _selector control with the wizard?

@mxmilkiib
Copy link
Contributor Author

I still haven't stepped back to sorting out a process at the level of testing PRs/fork branches yet. Not doing stuff with music was making me not want to bother with anything, but I realise I need to, so I'll work on that next (I did start again earlier by trying to pattern match hack the bpm fraction actions, but I just got upset. Simple testing of something should be easier, once I get into the flow. Just another form of consumption..)

@ronso0
Copy link
Member

ronso0 commented Feb 22, 2024

How exactly do you build Mixxx?

If you're using git you can have your safe personal branch and checkout branches, or pick individual commits.

@mxmilkiib
Copy link
Contributor Author

I need to switch from using the system that does the entire process, including the creation of a package archive that then allows the build install to be directly interrogated/managed by the package manager, to a solo git repository.

The former system extracts the working directory from a bare repo on every initiation of the build process (unless --no-extract is used, but building from a clean tree of the last commit is the standard) which isn't conducive to the process of multiple branch/fork orientated development/testing (AFAIU, maybe some git+Arch wizard could resolve these paradigms, but that's beyond me)

@ronso0
Copy link
Member

ronso0 commented Feb 22, 2024

You can run builds directly from the build dir, no need to install or create a package. If you want to remove the build, just clear or delete the build dir.

So, if you can already build the package, all dependencies should already be installed and you can follow the simple procedure explained in https://github.com/mixxxdj/mixxx/?tab=readme-ov-file#building-mixxx
Except that you would not pick a branch (that requires adding the respective contributor's repo as git remote), but pick a PR with the gh utility gh pr checkout (-f) [number of PR], then switch to the build dir and just build.

I just updated the instruction in https://github.com/mixxxdj/mixxx/wiki/Testing#build-pr-branches-yourself accordingly.


Note that there may be some flags that need to be set, depending on the base branch. E.g. main should be build with QT6=ON, while in 2.4 that should be off (cmake will warn you in that case). You may even have different build dirs: I have one for main, one for 2.4 and one for my personal branch (and a bash alias to switch between them to have Eclispe pick up the correct compile-commands.json https://mixxx.zulipchat.com/#narrow/stream/247620-development-help/topic)/Work.20with.20Qt5.20.2F.20Qt6.20.2F.20custom.20build.20dir

@mxmilkiib
Copy link
Contributor Author

mxmilkiib commented Feb 23, 2024

Hmm.. I'm getting (with or without the -f);

05:18:54 milk@red:~/src/mixxx main 128 ± gh pr checkout -f 12251
fatal: ambiguous argument 'pr': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'
05:19:19 milk@red:~/src/mixxx main 128 ± git checkout upstream/pr/12251
Alias tip: gco upstream/pr/12251
error: pathspec 'upstream/pr/12251' did not match any file(s) known to git

Edit: facepalm gh='git show HEAD'. and the wrong number..

@mxmilkiib
Copy link
Contributor Author

That works for me!

It zooms pretty fast, so maybe there could be call to increase the number of zoom levels.

@ronso0
Copy link
Member

ronso0 commented Feb 23, 2024

Okay, let's move over to #12387

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants