Regression: Waveform overview seeking is broken in 2.6/main

[fwcd]

Bug Description

Seeking one of the waveforms doesn't seem to work correctly on the latest 2.6/main builds:

Screen.Recording.2024-11-29.at.15.12.20.mov

A quick bisect shows that the issue was introduced somewhere between 437db42 (good) and 0eccb1b (bad) (diff), so very likely here:

• Refactor ValueTransformer and WBaseWidget #13853

cc @Swiftb0y

Version

2.6-alpha-138-g0eccb1b2db (HEAD)

OS

macOS 15.1.1

[Swiftb0y]

ACK. Thanks for the report. I'll try to find some time to look into it.

[fwcd]

Did a finer-grained bisect, the issue was introduced somewhere in 3aea4ed.

[Swiftb0y]

I see, that kinda makes sense. I will double check there.

[Swiftb0y]

I'm fairly certain I made a copy-paste error here with Right, it should've been None. I'll verify locally and open a PR.

mixxx/src/skin/legacy/legacyskinparser.cpp

Lines 2472 to 2478 in 0eccb1b

	if (directionOption & ControlParameterWidgetConnection::DIR_TO_WIDGET) {
	pWidget->addAndSetDisplayConnection(std::move(pConnection),
	WBaseWidget::ConnectionSide::Right);
	} else {
	pWidget->addConnection(std::move(pConnection),
	WBaseWidget::ConnectionSide::Right);
	}