Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide devcontainer config #13914

Open
spotlesscoder opened this issue Nov 21, 2024 · 2 comments · May be fixed by #14018
Open

Provide devcontainer config #13914

spotlesscoder opened this issue Nov 21, 2024 · 2 comments · May be fixed by #14018
Labels
feature

Comments

@spotlesscoder
Copy link
Contributor

Feature Description

I want to save time setting up the development environment of mixxx and also keep my system clean not installing compilers and libraries to my PC

The devcontainer specification allows to install dependencies etc. in a Docker Container and more and more IDEs are supporting to develop the code in such a container while preserving all IDE features for debugging / code analysis, language server etc.

See this example I built for Rust: https://github.com/spotlesscoder/rust-template
Just clone in VSCode, install the devcontainer extension in VS Code, run the "Reopen in Container" Action and everything installs automatically and you're ready to go
Once done trying out you can delete the docker container and the cloned git folder and your system is as clean as before

I want to provide something similar for the C++ stack that mixxx needs and make a PR for .devcontainer/ folder with the necessary config files in the repo root.
Would you be accepting such a PR?
@acolombier
Copy link
Member

Personally, I am 100% for this. I also use devcontainer and this could be a way for me to address Mixxx dropping support for Ubuntu 22.04.
One limitation is the fact that Windows and mac developer would be effectively be working with the Linux source if they decide to work in devcontainer, and would require a WSL integration/XQuartz to run the built version of Mixxx.
I don't mind, since a devcontainer is optional, and Windows/mac devs will still be able to work with a a system/vcpkg setup.
My only request would be to keep any IDE specific config out and work off the official spec and not include any customizations.<IDE> in there.

@acolombier
Copy link
Member

@mixxxdj/developers are you happy with this being added to the repo as well?

@acolombier acolombier linked a pull request Dec 14, 2024 that will close this issue
Draft
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Devcontainer support acolombier/mixxx
2 participants
@acolombier @spotlesscoder