Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Traktor Kontrol S4 Mk3: stop end_of_track flashing when deck is stopped #13995

Open
ronso0 opened this issue Dec 6, 2024 · 2 comments · May be fixed by #14028
Open

Traktor Kontrol S4 Mk3: stop end_of_track flashing when deck is stopped #13995

ronso0 opened this issue Dec 6, 2024 · 2 comments · May be fixed by #14028
Assignees
@acolombier
Labels
bug confirmed controller mappings

Comments

@ronso0
Copy link
Member

ronso0 commented Dec 6, 2024 •
edited
Loading

Bug Description

... both when deck is stopped manually and when it reaches the end and stops.

mixxx/res/controllers/Traktor-Kontrol-S4-MK3.js

Line 2571 in 8354c8e

if (engine.getValue(this.group, "end_of_track") && WheelLedBlinkOnTrackEnd) {

I fixed it for auto-stop with the additonal condition fractionOfTrack !== 1.0, but for when the deck is stopped manually I didn't manage to install a callback for end_of track itself and set/read a deck var appropriately (still a noob in js/components..)

@acolombier is that something that you already fixed in WIP/private versions of the script?

Version

2.4++

OS

No response
@acolombier
Copy link
Member

this is something I had started looking at but never submitted anything. Looking at it now...

@acolombier acolombier self-assigned this Dec 16, 2024
@ronso0
Copy link
Member Author

ronso0 commented Dec 16, 2024

I also have a solution in my personal version, could submit it but need to separate it because I tweaked .. a lot (personal preferences).

@acolombier acolombier linked a pull request Dec 16, 2024 that will close this issue
Open
@ronso0 ronso0 linked a pull request Dec 21, 2024 that will close this issue
S4MK3: stop wheel led blinking when track is over/stopped #14028
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@acolombier acolombier

Labels
bug confirmed controller mappings
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

S4MK3: stop wheel led blinking when track is over/stopped acolombier/mixxx
2 participants
@ronso0 @acolombier