Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(fix) Deere64: bring back library in regular view #14101

Merged
merged 1 commit into from
Jan 2, 2025
Merged

(fix) Deere64: bring back library in regular view #14101

merged 1 commit into from
Jan 2, 2025

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented Jan 2, 2025

fixes #14097

@github-actions github-actions bot added the skins label Jan 2, 2025
@ronso0 ronso0 linked an issue Jan 2, 2025 that may be closed by this pull request
Deere64 - Library isn't showing on the application #14097
Closed
@ronso0 ronso0 mentioned this pull request Jan 2, 2025
Closed
@Eve00000
Copy link
Contributor

Eve00000 commented Jan 2, 2025

I can confirm, this pr solves the issue in #14097. not causing any problem in others skins. All skins are fine now.
Remark: when "ask me again" in 'hide menu bar dialog is selected, a change of skin causes the diaolog to appear 5 times (behind each other), to hit 'hide', you need to go to the latest dialog with alt-tab or through taskbar. (De-)activating fullscreen with F11 causes this dialog to show up again (1 time).

@Eve00000 Eve00000 mentioned this pull request Jan 2, 2025
Open
Swiftb0y
Swiftb0y approved these changes Jan 2, 2025
View reviewed changes
Copy link
Member

@Swiftb0y Swiftb0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As confirmed by @Eve00000. The menu bar dialog is unrelated.

@Swiftb0y Swiftb0y merged commit 91ea847 into mixxxdj:2.5 Jan 2, 2025
13 checks passed
@ronso0 ronso0 deleted the deere64-library-fix branch January 2, 2025 11:40
@ronso0 ronso0 mentioned this pull request Jan 13, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Swiftb0y Swiftb0y Swiftb0y approved these changes

Assignees
No one assigned
Labels
skins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deere64 - Library isn't showing on the application
3 participants
@ronso0 @Eve00000 @Swiftb0y