Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

It will go to top on taht page when you click togle switch when it is open detail #220

Open
oyajun opened this issue Jul 1, 2022 · 2 comments · May be fixed by #773
Open

It will go to top on taht page when you click togle switch when it is open detail #220

oyajun opened this issue Jul 1, 2022 · 2 comments · May be fixed by #773
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@oyajun
Copy link
Contributor

oyajun commented Jul 1, 2022

top.webm
@mjakeman mjakeman added bug Something isn't working help wanted Extra attention is needed labels Aug 1, 2022
@oscfdezdz
Copy link
Collaborator

Related to

  • Toggle extensions without recreating the group

in #485

oscfdezdz added a commit that referenced this issue Apr 6, 2024
@oscfdezdz
manager: Sort extension list when sort-enabled-first is enabled
fa89369 
Fix #220
@oscfdezdz oscfdezdz mentioned this issue Apr 6, 2024
Closed
@mjakeman mjakeman mentioned this issue Jun 5, 2024
Closed
3 tasks
oscfdezdz added a commit that referenced this issue Aug 8, 2024
@oscfdezdz
manager: Sort extension list when sort-enabled-first is enabled
1d460bb 
Fix #220
oscfdezdz added a commit that referenced this issue Dec 27, 2024
@oscfdezdz
manager: Sort extension list when sort-enabled-first is enabled
e7580fa 
Fix #220
oscfdezdz added a commit that referenced this issue Jan 5, 2025
@oscfdezdz
manager: Resort extension list only with sort-enabled-first
6c9330b 
Helps #220
oscfdezdz added a commit that referenced this issue Feb 2, 2025
@oscfdezdz
installed-page: Save extensions' toggles focus on state changes
98cc6bd 
The items-changed signal is now emitted unchanged in the model from
ExmManager and is connected after binding the manager in
ExmInstalledPage from where the callback saves, emits items-changed and
restores focus.

This approach allows to keep binding GtkListBox to the extensions model
and not having to manage the changes manually.

Fix #220
oscfdezdz added a commit that referenced this issue Feb 2, 2025
@oscfdezdz
installed-page: Save extension's toggle focus on state changes
64d0c35 
The items-changed signal is now emitted unchanged in the model from
ExmManager and is connected after binding the manager in
ExmInstalledPage from where the callback saves, emits items-changed and
restores focus.

This approach allows to keep binding GtkListBox to the extensions model
and not having to manage the changes manually.

Fix #220
oscfdezdz added a commit that referenced this issue Feb 2, 2025
@oscfdezdz
installed-page: Save extension's toggle focus on state changes
bb29b6e 
The items-changed signal is now emitted without adding or removing items
to the model from ExmManager and is connected after binding the manager
in ExmInstalledPage from where the callback saves, emits items-changed
adding and removing as done before in ExmManager, and restores focus.

This approach allows us to keep binding GtkListBox to the extensions
model and not having to manage the changes manually.

Fix #220
@oscfdezdz oscfdezdz linked a pull request Feb 2, 2025 that will close this issue
Open
@oscfdezdz
Copy link
Collaborator

oscfdezdz commented Feb 2, 2025 •
edited
Loading

#773 saves the scroll position scrolls when the sort enabled first option is active with any change in the switches and consequent change of focus but it doesn't prevent the expanders from collapsing and altering the position, that would be fixed when we get rid of the expander.

oscfdezdz added a commit that referenced this issue Feb 2, 2025
@oscfdezdz
installed-page: Save extension's toggle focus on state changes
f6149ef 
The items-changed signal is now emitted without adding or removing items
to the model from ExmManager and is connected after binding the manager
in ExmInstalledPage from where the callback saves, emits items-changed
adding and removing as done before in ExmManager, and restores focus.

This approach allows us to keep binding GtkListBox to the extensions
model and not having to manage the changes manually.

Fix #220
oscfdezdz added a commit that referenced this issue Feb 3, 2025
@oscfdezdz
installed-page: Save extension's toggle focus on state changes
4280005 
The items-changed signal is now emitted without adding or removing items
to the model from ExmManager and is connected after binding the manager
in ExmInstalledPage from where the callback saves, emits items-changed
adding and removing as done before in ExmManager, and restores focus.

This approach allows us to keep binding GtkListBox to the extensions
model and not having to manage the changes manually.

Fix #220
oscfdezdz added a commit that referenced this issue Feb 3, 2025
@oscfdezdz
installed-page: Save extension's toggle focus on state changes
9bfb9aa 
The items-changed signal is now emitted without adding or removing items
to the model from ExmManager and is connected after binding the manager
in ExmInstalledPage from where the callback saves, emits items-changed
adding and removing as done before in ExmManager, and restores focus.

This approach allows us to keep binding GtkListBox to the extensions
model and not having to manage the changes manually.

Fix #220
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

installed-page: Save extension's toggle focus on state changes mjakeman/extension-manager
3 participants
@mjakeman @oscfdezdz @oyajun