Add local search #717
Merged
Add local search #717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
From the way we have the UI structured, I'd say that there aren't many options to avoid adding several getters and duplicating part of the code. Another option could be as parameters, properties or some other way that I'm not contemplating now. I think that's what you were referring to in #8 (comment). |
oscfdezdz
force-pushed
the
oscfdezdz/local-search
branch
3 times, most recently
from
4864ccc
to
cbd6d91
Compare
oscfdezdz
force-pushed
the
oscfdezdz/local-search
branch
2 times, most recently
from
59ce94c
to
19a5bd8
Compare
Use GtkBoolFilter with ExmExtension `is-user` property to split it into user and system lists when needed in the user interface.
Of the files modified in the previous commits.
oscfdezdz
force-pushed
the
oscfdezdz/local-search
branch
from
19a5bd8
to
813dccb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should be a step forward for unified search in the future, rather than a blocker, hopefully.
Marked as draft as the code has plenty of room for improvement.Close #8