Improve network error handling #729
Merged
+207
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscfdezdz
force-pushed
the
oscfdezdz/network-error
branch
2 times, most recently
from
cb47f46
to
469c757
Compare
oscfdezdz
force-pushed
the
oscfdezdz/network-error
branch
2 times, most recently
from
e6257f8
to
a07b015
Compare
oscfdezdz
force-pushed
the
oscfdezdz/network-error
branch
from
a07b015
to
8efe8d6
Compare
oscfdezdz
commented
Oct 31, 2024
oscfdezdz
force-pushed
the
oscfdezdz/network-error
branch
from
fe1b412
to
1b41f9a
Compare
Also tweaks "No Results Found" stack page.
oscfdezdz
force-pushed
the
oscfdezdz/network-error
branch
from
1b41f9a
to
583f826
Compare
oscfdezdz
added a commit
that referenced
this pull request
Nov 23, 2024
Overlooked in #729 and required to handle extensions that are not hosted on the Extensions website.
oscfdezdz
added a commit
that referenced
this pull request
Nov 23, 2024
Overlooked in #729 and required to handle extensions that are not hosted on the Extensions website.
oscfdezdz
added a commit
that referenced
this pull request
Nov 23, 2024
Overlooked in #729 and required to handle extensions that are not hosted on the Extensions website.
oscfdezdz
added a commit
that referenced
this pull request
Nov 23, 2024
Overlooked in #729 and required to handle extensions that are not hosted on the Extensions website. Not needed for browse page as it checks the size of the results list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It still needs some testing and probably the subtitles need to be more precise depending on the situation.Addresses #672 (comment)