Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regex for bgp-large-community-type is broken #363

Open
mjethanandani opened this issue Sep 8, 2023 · 1 comment
Open

Regex for bgp-large-community-type is broken #363

mjethanandani opened this issue Sep 8, 2023 · 1 comment
Assignees

Comments

@mjethanandani
Copy link
Owner

Issue reported by Maria Matekja on this thread - https://mailarchive.ietf.org/arch/msg/idr/3rVyYyqVHIy9lMk12CPobFJ3CSo/

Regex on pages 112-113 representing bgp-large-community-type doesn't match 4199999999:0:0 which is an obvious bug. Our suggestion is to make it a container:

container bgp-large-community {
leaf asn { type uint32; }
leaf data1 { type uint32; }
leaf data2 { type uint32; }
}

This also aligns better with RFC 8092 where the large community is defined as a block of three uint32 values.

@mjethanandani
Copy link
Owner Author

Fix the regex. Rest is up for discussion.

@mjethanandani mjethanandani self-assigned this Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants