This repository has been archived by the owner on Oct 22, 2024. It is now read-only.
Validate that EC2 instances only have one security group attached #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Shen <[email protected]>
mjlshen
force-pushed
the
instance-sg-count
branch
from
32741e5 to
907b570
Compare
|
fyi @boranx I've been running your code out in the wild and found some low hanging fruit to add to this instance validation when we found a cluster that was alerting because there were additional security groups attached by the customer :D |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This handles part of #58 to ensure only one security group is attached and adds unit tests